Linus Groh
8b035b80d3
LibJS: Update order of steps in CanonicalNumericIndexString
...
This is an editorial change in the ECMA-262 spec.
See: be5db32
2022-05-03 22:49:31 +02:00
Linus Groh
367e7b4fe5
LibJS: Reflect Array.prototype.toLocaleString comment in %TypedArray%
...
This is an editorial change in the ECMA-262 spec.
See: 2a9ed48
2022-05-03 22:49:31 +02:00
Linus Groh
b9bbf45a81
LibJS: Add assertion (comment) to MakeMatchIndicesIndexPairArray
...
This is an editorial change in the ECMA-262 spec.
See: caa6e3f
2022-05-03 22:49:31 +02:00
Linus Groh
ede932287f
LibJS: Update spec comments to avoid = comparisons with signed zero
...
This is an editorial change in the ECMA-262 spec.
See: b7348e5
2022-05-03 22:49:31 +02:00
Linus Groh
257375f54c
LibJS: Update comments for Annex B changes to IsLooselyEqual
...
This is an editorial change in the ECMA-262 spec.
See: da3d674
2022-05-03 22:49:31 +02:00
Linus Groh
17fb40bc42
LibJS: Fix type confusion in msFromTime
...
This is an editorial change in the ECMA-262 spec.
See: 8e572b6
2022-05-03 22:49:31 +02:00
Linus Groh
03e13715ac
LibJS: Update two comments saying "completion value"
...
This is an editorial change in the ECMA-262 spec.
See: 7913cea
2022-05-03 22:49:31 +02:00
Linus Groh
99cc442f5c
LibJS: Use more consistent wording for creating empty lists
...
This is an editorial change in the ECMA-262 spec.
See: 0bf22a9
2022-05-03 22:49:31 +02:00
Linus Groh
438e3ceb4a
LibJS: Use CreateDataPropertyOrThrow in MakeMatchIndicesIndexPairArray
...
This was part of a normative change in the ECMA-262 spec, but didn't get
updated when we implemented that.
See: 0209d85
2022-05-03 22:49:31 +02:00
Linus Groh
9f3f3b0864
LibJS: Remove implicit wrapping/unwrapping of completion records
...
This is an editorial change in the ECMA-262 spec, with similar changes
in some proposals.
See:
- 7575f74
- df899eb
- 9eb5a12
- c81f527
2022-05-03 01:09:29 +02:00
Linus Groh
8cbd25f553
LibJS: Simplify Is{Accessor,Data,Generic}Descriptor AOs
...
This is an editorial change in the ECMA-262 spec.
See: 1c7ae4b
2022-05-01 22:47:38 +02:00
Linus Groh
07ac8b7021
LibJS: Change "Record {}" to "Iterator Record {}" in comments
...
This is an editorial change in the ECMA-262 spec.
See: 85d910c
2022-05-01 22:47:38 +02:00
Linus Groh
c9bdd59e20
LibJS: Change "Completion {}" to "Completion Record {}" in comments
...
This is an editorial change in the ECMA-262 spec.
See: 15a7d8a
2022-05-01 22:47:38 +02:00
Linus Groh
719137418d
LibJS: Change "as [the] argument[s]" to "with arguments" in comments
...
This is an editorial change in the ECMA-262 spec.
See: e671b96
2022-05-01 22:47:38 +02:00
Linus Groh
214d5e3e83
LibJS: Update outdated table reference in BoundFunctionCreate
2022-05-01 22:47:38 +02:00
Linus Groh
7767f9be37
LibJS: Rename some variables from "script body" to "script"
...
This is an editorial change in the ECMA-262 spec.
See: 38a2584
2022-05-01 22:47:38 +02:00
Linus Groh
acda12597a
LibJS: Rename scope to environment
...
This is an editorial change in the ECMA-262 spec.
See: 3246553
2022-05-01 22:47:38 +02:00
Linus Groh
cb66474fb5
LibJS: Update spec comments testing presence of a field
...
This is an editorial change in the ECMA-262 spec.
See:
- 497f99a
- 0b35749
2022-05-01 22:47:38 +02:00
Linus Groh
d33fcad87f
LibJS: Update ValidateAndApplyPropertyDescriptor implementation
...
These are editorial changes in the ECMA-262 spec.
See:
- b9efa97
- 6f4ff96
- 3d18997
- b3c29fd
2022-05-01 22:47:38 +02:00
Linus Groh
85c16452f9
LibJS: Simplify Array.prototype.splice()
...
This is an editorial change in the ECMA-262 spec.
See: 193211a
2022-05-01 22:47:38 +02:00
Linus Groh
5a26a547db
LibJS: Update a couple of outdated spec comments
...
These are editorial changes in the ECMA-262 spec.
See:
- e080a7f
- c5a9094
- 5091520
- 1c6564b
- e06c80c
2022-05-01 22:47:38 +02:00
Linus Groh
ce659e5eeb
LibJS: Remove assertions that are now part of structured headers
...
This is an editorial change in the ECMA-262 spec.
See: 4fde514
2022-05-01 22:13:21 +02:00
Linus Groh
86e3840202
LibJS: Add missing comment in OrdinaryToPrimitive
2022-05-01 22:13:21 +02:00
Idan Horowitz
1a8b5ef80a
LibJS: Stop fetching GlobalObject from target's realm in ArrayBuffer
...
A function object's realm is not necessarily non-null (like when called
via the Reflect API), so we can't blindly dereference it. Instead use
the object's own GlobalObject.
2022-04-30 21:55:39 +02:00
Idan Horowitz
9098257668
LibJS: Reject -00000 as extended year in Date parsing
2022-04-30 21:36:27 +02:00
Idan Horowitz
0399239e3f
LibJS: Do not negate zero into negative zero in ToIntegerOrInfinity
...
When the input value was in the range of [-1, 0] we would incorrectly
negate the resulting integer, resulting in -0 instead of the expected 0
2022-04-30 21:35:16 +02:00
Idan Horowitz
7ac9900023
LibJS: Reorder parsing for TimeSpecWithOptionalTimeZoneNotAmbiguous
...
Because `TimeHour TimeZoneNumericUTCOffsetNotAmbiguous[opt]
TimeZoneBracketedAnnotation[opt]` can be a subset of
`TimeHourNotValidMonth TimeZone` we would not exhaust the whole input
in some cases, which would result in an incorrectly thrown exception.
2022-04-30 18:36:10 +02:00
Linus Groh
27793bf76c
LibJS: Replace U+2212 MINUS SIGN with U+002D HYPHEN-MINUS
...
This is an editorial change in the Temporal spec.
See: bbcd37b
2022-04-29 22:40:46 +02:00
Linus Groh
df1f81ba90
LibJS: Add notes about lifetime of surrounding agent
...
This is an editorial change in the Temporal spec.
See: 54e4abc
2022-04-29 22:40:46 +02:00
Linus Groh
76a6bd0e75
LibJS: Fix numeric type confusion in GetEpochFromISOParts return value
...
This is an editorial change in the Temporal spec.
See: 2a59eac
2022-04-29 22:40:46 +02:00
Linus Groh
70593b7448
LibJS: Update for structured headers added to various Temporal AOs
...
This is an editorial change in the Temporal spec.
See: e6a15a5
2022-04-29 22:40:46 +02:00
Linus Groh
9a3014c91a
LibJS: Drop "integral part of" language
...
This is an editorial change in the Temporal spec.
See: 6ec1608
2022-04-29 22:40:46 +02:00
Linus Groh
cb33320814
LibJS: Fix one more instance of Number value / integer confusion
...
This is an editorial change in the Temporal spec.
See: 5b1b783
2022-04-29 22:40:46 +02:00
Linus Groh
aac457755d
LibJS: Define IsBuiltinCalendar in terms of AvailableCalendars
...
This is an editorial change in the Temporal spec.
See: 896b72d
2022-04-29 22:40:46 +02:00
Linus Groh
2499911898
LibJS: Rename DateFromFields to CalendarDateFromFields, etc
...
This is an editorial change in the Temporal spec.
See: fd27b54
2022-04-29 22:40:46 +02:00
Linus Groh
7bf4a785c6
LibJS: Fix RoundNumberToIncrement spec number
2022-04-29 21:52:30 +02:00
Linus Groh
bc4a0baa8f
LibJS: Remove outdated FIXMEs about required date_from_fields() options
...
The `options` parameter is no longer required by the function, so we can
stop passing in options as well where not required by the spec.
2022-04-29 19:50:41 +02:00
Linus Groh
e815d3f9ce
LibJS: De-duplicate ClassFieldDefinition Records
...
This was defined twice, despite being the very same thing:
- ClassElement::ClassFieldDefinition
- ECMAScriptFunctionObject::InstanceField
Move the former to a new header and use it everywhere. Also update the
define_field() AO to take a single field instead of separate name and
initializer arguments.
2022-04-20 00:08:32 +02:00
Ali Mohammad Pur
e1cd36559d
LibJS: Make the BC generator.next(value) work
...
This used to put the value in the previous frame's accumulator register,
which is only correct for the first invocation of the generator.
2022-04-18 23:59:30 +04:30
Ali Mohammad Pur
d5791c85b4
LibJS: Avoid copying the frame into the interpreter in BC generators
2022-04-18 23:59:30 +04:30
Linus Groh
472ff7a6d4
LibJS: Don't coerce this value in %IteratorPrototype%[@@iterator]
...
Another day, another mistake that's been there for a long time but
would've been immediately obvious when adding spec comments. :^)
2022-04-18 00:24:02 +02:00
Linus Groh
ee1379520a
LibJS: Add missing whitespace around namespace curly braces
2022-04-17 23:00:35 +02:00
Timothy Flynn
6654efcd82
LibJS: Remove cloneConstructor parameter from CloneArrayBuffer
...
This is a normative change in the ECMA-262 spec. See:
e7979fd
Note that this implements a FIXME in InitializeTypedArrayFromTypedArray,
now that shared array buffers are no longer a concern there. We already
have test coverage for the now-handled case.
2022-04-16 16:49:52 +01:00
Timothy Flynn
39b308ba52
LibJS: Factor out TypedArrayElement{Size,Type} abstract operations
...
This is an editorial change in the ECMA-262 spec. See:
a90670d5
This also adds missing spec comments to the following prototypes which
were affected by this change:
Atomics.load
Atomics.store
%TypedArray%.prototype.slice
%TypedArray%.prototype.subarray
2022-04-16 16:49:52 +01:00
Timothy Flynn
0174993bea
LibJS: Add explicit ErrorType values for TypedArray prototype exceptions
2022-04-16 16:49:52 +01:00
Timothy Flynn
c20e8cea19
LibJS: Define AllocateTypedArrayBuffer AO out of line
...
Not only is it easier to compare to the spec when defined out of line,
but this AO was implemented inside other AOs twice.
2022-04-16 16:49:52 +01:00
Timothy Flynn
c076b363ce
LibJS: Define SetTypedArrayFrom{TypedArray,ArrayLike} AOs out of line
...
%TypedArray%.prototype.set was a bit hard to read / compare to the spec
with these AOs defined inside it.
2022-04-16 16:49:52 +01:00
Andreas Kling
343d699627
LibJS: Add missing Vector::in_reverse() in ensure_property_table()
...
Regressed with 35fcb028e9
.
2022-04-13 21:02:37 +02:00
Andreas Kling
35fcb028e9
LibJS: Tidy up Shape::ensure_property_table() a little bit
...
- Use a vector or references for the transition chain since null shapes
are not allowed in the chain.
- Use Vector::in_reverse() for iterating the chain backwards.
2022-04-13 19:52:25 +02:00
Timothy Flynn
4d0315099f
LibJS: Allow TypeArray to become detached in TypedArray.prototype.set
...
This is a normative change in the ECMA-262 spec. See:
4d570c4
2022-04-13 16:02:01 +02:00