Lenny Maiorani
c37820b898
Libraries: Use default constructors/destructors in LibWeb
...
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules
"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
2022-03-17 17:23:49 +00:00
Ali Mohammad Pur
117ca843bd
LibWeb: Don't check for get().is_empty() in WebAssemblyMemoryConstructor
...
Object.get() does not return empty values, this was causing the
constructed memory object to have a maximum of 0, which failed silently
in the constructor.
2022-02-16 22:48:32 +03:30
Linus Groh
5832de62fe
LibJS: Convert NativeFunction::{call,construct}() to ThrowCompletionOr
...
Both at the same time because many of them call construct() in call()
and I'm not keen on adding a bunch of temporary plumbing to turn
exceptions into throw completions.
Also changes the return value of construct() to Object* instead of Value
as it always needs to return an object; allowing an arbitrary Value is a
massive foot gun.
2021-10-21 09:02:23 +01:00
Idan Horowitz
cc94bba5c0
LibJS: Convert to_u32() to ThrowCompletionOr
2021-10-18 08:01:38 +03:00
Linus Groh
52976bfac6
LibJS: Convert to_object() to ThrowCompletionOr
2021-10-13 09:55:10 +01:00
Linus Groh
b7e5f08e56
LibJS: Convert Object::get() to ThrowCompletionOr
...
To no one's surprise, this patch is pretty big - this is possibly the
most used AO of all of them. Definitely worth it though.
2021-10-03 20:14:03 +01:00
Timothy Flynn
c59b97043e
LibWeb: Use ErrorType::NotAnObjectOfType instead of NotA
2021-09-12 00:16:39 +02:00
Brian Gianforcaro
217179a39f
LibWeb: Remove unused header includes
2021-08-01 08:10:16 +02:00
Idan Horowitz
a6b8291a9b
LibJS: Add define_direct_property and remove the define_property helper
...
This removes all usages of the non-standard define_property helper
method and replaces all it's usages with the specification required
alternative or with define_direct_property where appropriate.
2021-07-06 14:20:30 +01:00
Linus Groh
79d8326370
LibWeb: Use "WebAssembly.Foo" in exception error messages
...
Not just "Foo" or "WebAssemblyFoo". This is how it's accessed from the
outside (JS).
Also fix one case of "not an" => "not a".
2021-07-05 12:32:51 +01:00
Linus Groh
1ac3d253c5
LibWeb/WebAssembly+test-wasm: Use get_without_side_effects() more
2021-07-04 22:07:36 +01:00
Ali Mohammad Pur
de4cbc8f08
LibWeb: Use the correct name to refer to WebAssembly.Memory.prototype
...
Otherwise `instanceof` wouldn't return the correct result.
2021-07-02 04:53:01 +04:30
Andreas Kling
ba9d5c4d54
LibJS: Rename Function => FunctionObject
2021-06-27 22:36:04 +02:00
Ali Mohammad Pur
5c90c389c3
LibWeb: Implement the WebAssembly Memory object and Memory imports
2021-06-22 00:26:25 +04:30
