RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 17:47:43 +00:00
Code Issues Activity Actions
38703 commits 1 branch 0 tags 230 MiB
Commit graph

10863 commits

Author SHA1 Message Date
MacDue
c491ab7523 LibWeb: Only paint the background image on integer steps 
This avoids excessive over painting.
 2022-06-17 09:37:39 +01:00
Sam Atkins
c4ef4fcd72 LibWeb: Add deprecated image-rendering values 
From the spec:

> This property previously accepted the values optimizeSpeed and
  optimizeQuality. These are now deprecated; a user agent must accept
  them as valid values but must treat them as having the same behavior
  as pixelated and smooth respectively, and authors must not use them.

- https://www.w3.org/TR/css-images-3/#the-image-rendering
 2022-06-16 17:36:13 +01:00
FrHun
1b4ab8626b LibWeb: Disable unused error on temporarily unused variable from spec 2022-06-16 17:20:49 +01:00
Karol Kosek
ab6288fd3d LibWeb: Use SmoothPixels scaling mode as the pixelated rendering 
It's probably not in 1:1 as spec says, as it wants us to first upscale
the image to the nearest integer and then downscale it bilinearly.
But this mode still falls into the general description of the value:

> The image is scaled in a way that preserves the pixelated nature of
> the original as much as possible, but allows minor smoothing instead
> of awkward distortion when necessary.

Also, this way we don't have to allocate the memory just for the integer
scale. :^) :^)
 2022-06-16 14:26:55 +01:00
Karol Kosek
3d7838c5fb LibGfx: Implement SmoothPixels scaling mode 
If you wanted to upscale an image, you had two options:
- use Nearest Neighbor: it's probably a good choice. The image stays
  sharp.. unless you aren't using integer scales.
- use Bilinear blending, but this on the other hand, doesn't handle
  upscaling well. It just blurs everything.

But what if we could take the best of both of them and make the image
sharp on integers and just blur it a little when needed?

Well, there's Smooth Pixels!

This mode is similar to the Bilinear Blend, with the main difference
is that the blend ratio is multiplied by the current scale, so the blur
on corners can be only 1px wide.

From my testing this mode doesn't handles downscaling as good as the
Bilinear blending though.
 2022-06-16 14:26:55 +01:00
Karol Kosek
c409881b5f LibGfx: Pass scaling mode as an enum in do_draw_scaled_bitmap 2022-06-16 14:26:55 +01:00
MacDue
4d110c39f3 LibWeb: Support using border-radius on <img> tags 2022-06-16 10:28:07 +01:00
MacDue
5b6abfadfd LibWeb: Make PaintableBox::normalized_border_radii_data() protected 
This method is needed in subclasses of PaintableBox to do
border-radius clipping.
 2022-06-16 10:28:07 +01:00
MacDue
4e8e1492f9 LibWeb: Support using border-radius with a background-image 2022-06-16 10:28:07 +01:00
MacDue
830632407f LibWeb: Add BorderRadiusCornerClipper 
This is a helper class for clipping the corners off a element.

This works in a similar way to how (outline) borders are painted.

The steps are:
  1. A small bitmap that fits only the corners is allocated
  2. The corners are painted into the bitmap
  3. The existing pixels (where the corners will be painted)
     are copied using the (inverse) corner bitmap as a mask
     (done before the element is painted)
  4. The element is painted
  5. The areas outside the corner radii are restored

Like with the borders, this only requires allocation on the first
paint.
 2022-06-16 10:28:07 +01:00
MacDue
4dfbbd5965 LibWeb: Move border corner bitmap getter/cache to function 
This will allow the same bitmap to be shared between border,
background, and various other corner clipping code.
 2022-06-16 10:28:07 +01:00
MacDue
81a3ec0692 LibGfx: Add Painter::get_pixel() 
This is required to do some painting tricks in LibWeb, this has to be
added to the painter so it can apply the paint translation first.
 2022-06-16 10:28:07 +01:00
Thomas Fach-Pedersen
019e3a342d LibWeb: Parse rgb and hsl functions according to CSS Module Level 4 
Implement parsing of rgb(..) and hsl(..) in both the modern level 4
syntax without commas, and the legacy syntax with commas.

The parser accepts non-integer numbers but rounds to integer values
for now.
 2022-06-15 19:10:43 +01:00
Thomas Fach-Pedersen
83c79fec1c LibWeb: Fix calculation of degrees from radians 2022-06-15 19:10:43 +01:00
Linus Groh
2c647da0b5 LibJS: Mark AddInstant in AddZonedDateTime as fallible 
This is an editorial change in the Temporal spec.

See: 8bc0f98
 2022-06-15 17:49:20 +01:00
Linus Groh
b2965cf204 LibJS: Fix Instant rounding modes 
This is a normative change in the Temporal spec.

See: 0993b75
 2022-06-15 17:49:20 +01:00
Linus Groh
1755d051fd LibJS: Mark two calls as infallible in DifferenceTemporalPlainTime 
This is an editorial change in the Temporal spec.

See: 0e4966a
 2022-06-15 17:49:20 +01:00
Linus Groh
36ef604905 LibJS: Assume options is an object in the DifferenceZonedDateTime AO 
This is an editorial change in the Temporal spec.

See: a6662f1
 2022-06-15 17:49:20 +01:00
Linus Groh
52a4ee563d LibJS: Assume options is an object in the MergeLargestUnitOption AO 
This is an editorial change in the Temporal spec.

See: 20a04ac
 2022-06-15 17:49:20 +01:00
Linus Groh
569c2dc1d0 LibJS: Adjust order of operations in ISO{Date,MonthDay}FromFields 
This is a normative change in the Temporal spec.

See: 7dd90dc
 2022-06-15 17:49:20 +01:00
Linus Groh
3bc54ac75a LibJS: Mark a call of CreateDurationRecord as fallible 
This is an editorial change in the Temporal spec.

See: 462f027
 2022-06-15 17:49:20 +01:00
Linus Groh
81b9a2e4a1 LibJS: Mark a call of CreateDateDurationRecord as fallible 
This is an editorial change in the Temporal spec.

See: 5411f62
 2022-06-15 17:49:20 +01:00
Linus Groh
8be4cc9653 LibJS: Make options mandatory in Difference{Zoned,ISO}DateTime 
This is an editorial change in the Temporal spec.

See: d4c4a16
 2022-06-15 17:49:20 +01:00
Linus Groh
eaf6f20ed1 LibJS: Move assertion step around in Calendar.prototype.mergeFields 
This is an editorial change in the Temporal spec.

See: f790821
 2022-06-15 17:49:20 +01:00
Linus Groh
c0986be2c1 LibJS: Use consistent alias names for object-copy steps 
This is an editorial change in the Temporal spec.

See: 6669bad
 2022-06-15 17:49:20 +01:00
Linus Groh
e68173b656 LibJS: Update AvailableCalendars AO to reflect spec changes 
These are editorial and normative changes in the Temporal spec.

See:
- 2c977fc
- 3af75ec
- 75ea812
- e7be49b
- 883e00a
- 5b9d76a
 2022-06-15 17:49:20 +01:00
Linus Groh
3025f77991 LibJS: Add an explicit operation for merging calendar field names 
This is an editorial change in the Temporal spec.

See: 2bd7977
 2022-06-15 17:49:20 +01:00
Linus Groh
ee80164ac1 LibJS: Remove unnecessary variable initialization in DifferenceISODate 
This is an editorial change in the Temporal spec.

See: ca1abdc
 2022-06-15 17:49:20 +01:00
Linus Groh
fafc9b07c4 LibJS: Mark AO calls creating a copy of built-in objects as infallible 
This is an editorial change in the Temporal spec.

See: 536f067
 2022-06-15 17:49:20 +01:00
Linus Groh
be2c86002a LibJS: Handle absent options in DifferenceZonedDateTime 
This is an editorial change in the Temporal spec.

See: edc223c
 2022-06-15 17:49:20 +01:00
Linus Groh
5eb48f6f3a LibJS: Remove constant arguments from CalculateOffsetShift 
This is an editorial change in the Temporal spec.

See: 0bc5f9d
 2022-06-15 17:49:20 +01:00
Linus Groh
2ce3d4389a LibJS: Use existing variable instead of re-reading internal slot 
This is an editorial change in the Temporal spec.

See: 8d62569
 2022-06-15 17:49:20 +01:00
Linus Groh
a7dfe9096c LibJS: Switch branches in RegulateISODate 
This is an editorial change in the Temporal spec.

See: 2e4a06f
 2022-06-15 17:49:20 +01:00
Linus Groh
07041498f8 LibJS: Inline ConstrainISOYearMonth into RegulateISOYearMonth 
This is an editorial change in the Temporal spec.

See: c97932b
 2022-06-15 17:49:20 +01:00
Linus Groh
aaa9524a52 LibJS: Add parentheses around modulo operation 
This is an editorial change in the Temporal spec.

See: 90e4b34
 2022-06-15 17:49:20 +01:00
Linus Groh
287dd03e2e LibJS: Use nsMinInstant / nsMaxInstant constants in ParseTemporalInstant 
This is an editorial change in the Temporal spec.

See: a045682
 2022-06-15 17:49:20 +01:00
Linus Groh
690585323d LibJS: Prefer Else + Assertion over If for constrained values 
This is an editorial change in the Temporal spec.

See: 2088eaa
 2022-06-15 17:49:20 +01:00
Linus Groh
9b3602d000 LibJS: Update missing/superfluous commas in various spec comments 
These are editorial changes in the Temporal spec.

See:
- 9586746
- 3c76ecc
- 96eab07
 2022-06-15 17:49:20 +01:00
Linus Groh
30328d74d0 LibJS: Use MaximumTemporalDurationRoundingIncrement in two more places 
This is an editorial change in the Temporal spec.

See: de582e2
 2022-06-15 17:49:20 +01:00
Linus Groh
6c82c9df79 LibJS: Fix GetIterator capitalization in Calendar.prototype.fields 
This is an editorial change in the Temporal spec.

See: 8538970
 2022-06-15 17:49:20 +01:00
Linus Groh
9d2377ff60 LibJS: Only call CanonicalizeTimeZoneName on valid time zone IDs 
This is an editorial change in the Temporal spec.

See: 30122e6
 2022-06-15 17:49:20 +01:00
Linus Groh
cf61d01140 LibJS: Add a named alias for parseResult.[[Name]] in ToTemporalTimeZone 
This is an editorial change in the Temporal spec.

See: 8ddcb07
 2022-06-15 17:49:20 +01:00
Linus Groh
71a519831d LibJS: Update to the latest ECMA-402 GetOption and move it into ECMA-262 
This is an editorial change in the Temporal spec.

See: 4e79b69
 2022-06-15 17:49:20 +01:00
Linus Groh
46d2ac6da4 LibJS: Align Temporal GetOption AO with ECMA-402 
This is an editorial change in the Temporal spec.

See: 7b6a264
 2022-06-15 17:49:20 +01:00
Linus Groh
c8d84f33b0 LibJS: Remove unused GetStringOrNumberOption operation 
This is an editorial change in the Temporal spec.

See: d8b3423
 2022-06-15 17:49:20 +01:00
Linus Groh
d1b71cba25 LibJS: Explicitly handle "auto" vs. number fractionalSecondDigits 
This is an editorial change in the Temporal spec.

See:
- 4dd6713
- 4c2476b
- f1a839b
- c775ebe
- 0409774

(Changes across multiple commits, that ended up being reverted.)
 2022-06-15 17:49:20 +01:00
Linus Groh
cbc4cf057d LibJS: Improve an alias name in ToSecondsStringPrecision 
This is an editorial change in the Temporal spec.

See: b75bd9e
 2022-06-15 17:49:20 +01:00
Linus Groh
4494be8cf2 LibJS: Inline call to AddISODate in ZonedDateTime.prototype.hoursInDay 
This is an editorial change in the Temporal spec.

See: f034239
 2022-06-15 17:49:20 +01:00
Linus Groh
810e9e32c9 LibJS: Remove RegulateISODate after BalanceISODate in AddISODate 
This is an editorial change in the Temporal spec.

See: 32b22b1
 2022-06-15 17:49:20 +01:00
Linus Groh
e96df3b7a7 LibJS: Leverage PrepareTemporalFields in ToTemporalTimeRecord 
This is an editorial change in the Temporal spec.

See: b5ba981
 2022-06-15 17:49:20 +01:00