8 commits

Author	SHA1	Message	Date
Andreas Kling	e0f32626bc	LibGfx: Rename 32-bit BitmapFormats to BGRA8888 and BGRx888x ... The previous names (RGBA32 and RGB32) were misleading since that's not the actual byte order in memory. The new names reflect exactly how the color values get laid out in bitmap data.	2021-03-16 11:50:03 +01:00
Andreas Kling	5d180d1f99	Everywhere: Rename ASSERT => VERIFY ... (...and ASSERT_NOT_REACHED => VERIFY_NOT_REACHED) Since all of these checks are done in release builds as well, let's rename them to VERIFY to prevent confusion, as everyone is used to assertions being compiled out in release. We can introduce a new ASSERT macro that is specifically for debug checks, but I'm doing this wholesale conversion first since we've accumulated thousands of these already, and it's not immediately obvious which ones are suitable for ASSERT.	2021-02-23 20:56:54 +01:00
AnotherTest	09a43969ba	Everywhere: Replace dbgln<flag>(...) with dbgln_if(flag, ...) ... Replacement made by `find Kernel Userland -name '*.h' -o -name '*.cpp' | sed -i -Ee 's/dbgln\b<(\w+)>\(/dbgln_if(\1, /g'`	2021-02-08 18:08:55 +01:00
Ben Wiederhake	4332dfb964	LibGfx: Fix dynamic bitmasks in BMPs ... I overlooked a corner case where we might call the built-in ctz() on zero. Furthermore, the calculation of the shift was wrong and the results were often unusable. Both issue were caused by a forgotten 36daeee34f. This time I made sure to look at bmpsuite_files first, and now they look good. Found by OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=28985	2021-01-30 09:23:18 +01:00
asynts	8465683dcf	Everywhere: Debug macros instead of constexpr. ... This was done with the following script: find . \( -name '*.cpp' -o -name '*.h' -o -name '*.in' \) -not -path './Toolchain/*' -not -path './Build/*' -exec sed -i -E 's/dbgln<debug_([a-z_]+)>/dbgln<\U\1_DEBUG>/' {} \; find . \( -name '*.cpp' -o -name '*.h' -o -name '*.in' \) -not -path './Toolchain/*' -not -path './Build/*' -exec sed -i -E 's/if constexpr \(debug_([a-z0-9_]+)/if constexpr \(\U\1_DEBUG/' {} \;	2021-01-25 09:47:36 +01:00
asynts	d69a8a9958	Everywhere: Replace a bundle of dbg with dbgln. ... These changes are arbitrarily divided into multiple commits to make it easier to find potentially introduced bugs with git bisect.	2021-01-22 22:14:30 +01:00
Andreas Kling	7a0bc2fdb8	LibGfx: Convert all the dbg() in BMPLoader to dbgln() ... Also get rid of the awkward IF_BMP_DEBUG macro while we're here.	2021-01-17 15:42:10 +01:00
Andreas Kling	13d7c09125	Libraries: Move to Userland/Libraries/	2021-01-12 12:17:46 +01:00

Renamed from Libraries/LibGfx/BMPLoader.cpp (Browse further)