RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 22:22:45 +00:00
Code Issues Activity Actions
40225 commits 1 branch 0 tags 230 MiB
Commit graph

52 commits

Author SHA1 Message Date
Timothy Flynn
a712c7b5e1 LibJS: Replace comparisons of "0"_bigint with SignedBigInteger::is_zero 
This just avoids creating UnsignedBigInteger's underlying vector.
 2022-07-18 08:51:07 +01:00
Linus Groh
ee0d5d6649 LibJS: Refactor common option reading into the GetDifferenceSettings AO 
This is an editorial change in the Temporal spec.

See: 78abbb8
 2022-06-24 22:12:03 +01:00
Linus Groh
3679f671b9 LibJS: Mark some calls of CreateTemporalDate as infallible 
This is an editorial change in the Temporal spec.

See: 30344e8
 2022-06-24 22:12:03 +01:00
Linus Groh
7b5a7e7759 LibJS: Check for invalid epoch nanoseconds in NanosecondsToDays 
This is a normative change in the Temporal spec.

See: f1f016e
 2022-06-24 22:12:03 +01:00
Linus Groh
ddea6d451b LibJS: Check for invalid epoch nanoseconds in InterpretISODateTimeOffset 
This is a normative change in the Temporal spec.

See: cdfe4a5
 2022-06-24 22:12:03 +01:00
Linus Groh
2c647da0b5 LibJS: Mark AddInstant in AddZonedDateTime as fallible 
This is an editorial change in the Temporal spec.

See: 8bc0f98
 2022-06-15 17:49:20 +01:00
Linus Groh
36ef604905 LibJS: Assume options is an object in the DifferenceZonedDateTime AO 
This is an editorial change in the Temporal spec.

See: a6662f1
 2022-06-15 17:49:20 +01:00
Linus Groh
52a4ee563d LibJS: Assume options is an object in the MergeLargestUnitOption AO 
This is an editorial change in the Temporal spec.

See: 20a04ac
 2022-06-15 17:49:20 +01:00
Linus Groh
8be4cc9653 LibJS: Make options mandatory in Difference{Zoned,ISO}DateTime 
This is an editorial change in the Temporal spec.

See: d4c4a16
 2022-06-15 17:49:20 +01:00
Linus Groh
be2c86002a LibJS: Handle absent options in DifferenceZonedDateTime 
This is an editorial change in the Temporal spec.

See: edc223c
 2022-06-15 17:49:20 +01:00
Linus Groh
9b3602d000 LibJS: Update missing/superfluous commas in various spec comments 
These are editorial changes in the Temporal spec.

See:
- 9586746
- 3c76ecc
- 96eab07
 2022-06-15 17:49:20 +01:00
Linus Groh
3e6561c75f LibJS: Fold PreparePartialTemporalFields into PrepareTemporalFields 
This is an editorial change in the Temporal spec.

See: 6ed1835
 2022-06-15 17:49:20 +01:00
Linus Groh
4c77575ec5 LibJS: Simplify Temporal unit AOs 
This is an editorial change in the Temporal spec.

See: 1b3d018
 2022-06-10 12:39:11 +02:00
Linus Groh
ae1fdf299d LibJS: Use the rounding abstract operations from Intl.NumberFormat V3 
This is an editorial change in the Temporal spec.

See: 75279e5

Co-Authored-By: Idan Horowitz <idan.horowitz@gmail.com>
 2022-05-25 00:25:23 +01:00
Linus Groh
74695ce76e LibJS: Mark two Get operations in ToTemporalZonedDateTime infallible 
This is an editorial change in the Temporal spec.

See: fed9f16
 2022-05-17 21:24:50 +01:00
Linus Groh
80048c694a LibJS: Use '2 × nsMaxInstant' in a couple of assertion comments 
This is an editorial change in the Temporal spec.

See: a225863
 2022-05-09 20:27:20 +02:00
Linus Groh
cc8f5151d7 LibJS: Refactor Temporal since/until to common AOs 
This is an editorial change in the Temporal spec.

See: 85a9f57
 2022-05-08 00:07:58 +02:00
Linus Groh
c6f7214a60 LibJS: Replace magic nanosecond numbers with constants 
This is an editorial change in the Temporal spec.

See: 3fdbfda
 2022-05-08 00:07:58 +02:00
Linus Groh
3729a910f6 LibJS: Refactor Temporal add/subtract to common AOs 
This is an editorial change in the Temporal spec.

See:
- 2f96efc
- fbff635
 2022-05-08 00:07:58 +02:00
Linus Groh
27793bf76c LibJS: Replace U+2212 MINUS SIGN with U+002D HYPHEN-MINUS 
This is an editorial change in the Temporal spec.

See: bbcd37b
 2022-04-29 22:40:46 +02:00
Linus Groh
76a6bd0e75 LibJS: Fix numeric type confusion in GetEpochFromISOParts return value 
This is an editorial change in the Temporal spec.

See: 2a59eac
 2022-04-29 22:40:46 +02:00
Linus Groh
70593b7448 LibJS: Update for structured headers added to various Temporal AOs 
This is an editorial change in the Temporal spec.

See: e6a15a5
 2022-04-29 22:40:46 +02:00
Linus Groh
9a3014c91a LibJS: Drop "integral part of" language 
This is an editorial change in the Temporal spec.

See: 6ec1608
 2022-04-29 22:40:46 +02:00
Luke Wilde
c32dcf7f75 LibJS: Update ZonedDateTime AO spec comments for structured headers 
This is an editorial change in the Temporal spec.

See: 01714a5
 2022-04-11 23:47:02 +01:00
Linus Groh
e109b967a1 LibJS: Make options object const in more Temporal AOs 2022-04-08 00:43:17 +01:00
Linus Groh
151eb8606d LibJS: Consistently call observable Temporal AOs with undefined options 
This is a normative change in the Temporal spec.

See: 6fa5b9d
 2022-04-07 12:58:39 +01:00
Linus Groh
ff3256792d LibJS: Change nanoseconds_to_days() argument from a JS to Crypto BigInt 
This is an editorial change in the Temporal spec.

See: 0b1346c
 2022-03-19 19:28:49 +00:00
Linus Groh
039cb9f189 LibJS: Change nanoseconds_to_days() result from a JS to Crypto BigInt 
Similar to the preceding commit(s).
 2022-03-19 19:28:49 +00:00
Linus Groh
360c65e92b LibJS: Change balance_duration() nanoseconds from a JS to Crypto BigInt 
Similar to the preceding commit.
 2022-03-19 19:28:49 +00:00
Linus Groh
f75052ff7c LibJS: Assert CreateTemporalDuration does not throw given correct input 
This is an editorial change in the Temporal spec.

See: 881dd22
 2022-03-10 23:20:39 +01:00
Linus Groh
68af8649fb LibJS: Follow rules for consuming completion records 
This is an editorial change in the Temporal spec.

See: 1c19b96
 2022-03-10 23:20:39 +01:00
Linus Groh
2bae040bc9 LibJS: Remove Sign abstract operation 
This is an editorial change in the Temporal spec.

See: bbc1ebc
 2022-03-10 23:20:39 +01:00
Linus Groh
17da627b4c LibJS: Fix "set it to" language to be more explicit 
This is an editorial change in the Temporal spec.

See: de58241
 2022-03-10 23:20:39 +01:00
Linus Groh
a496868ee5 LibJS: Create Duration Records with their own abstract operations 
This is an editorial change in the Temporal spec.

See:
- 387c405
- b203e26
- 387c405
 2022-03-10 23:20:39 +01:00
Linus Groh
bdb13a74b0 LibJS: Describe various kinds of "Duration Records" 
This is an editorial change in the Temporal spec.

See: 983902e

We already had these defined as structs, but now they're properly
defined in the spec (opposed to the previous anonymous records), and we
don't have to make up our own names anymore :^)

Note that while we're usually not including 'record' in the name, in
this case the 'Duration Record' has a name clash with the Duration
object. Additionally, later editorial changes introduce CreateFooRecord
AOs, so let's just go with FooRecord structs here.
 2022-03-10 23:20:39 +01:00
Linus Groh
af7003ebd2 LibJS: Convert 'possible instants' AOs to MarkedVector<Instant*> 
Resolve TODOs suggesting the use of a strongly typed MarkedValueList
(a.k.a. MarkedVector<T>) in the following AOs:

- get_possible_instants_for()
- disambiguate_possible_instants()
 2022-02-09 12:25:27 +00:00
Linus Groh
6d744eb4a7 LibJS: Use consistent name for offset strings 
This is an editorial change in the Temporal spec.

See: 17f8cdb
 2022-01-23 00:22:10 +00:00
Linus Groh
b9093dd0ab LibJS: Don't validate time zone name when parsing Instant string 
This is normative change in the Temporal spec.

See: 2a81fbc
 2022-01-13 10:08:34 +01:00
Luke Wilde
16301a603c LibJS: Implement difference_zoned_date_time() 2021-11-24 17:53:00 +00:00
Linus Groh
1e41a8668d LibJS: Add sign(Crypto::SignedBigInteger const&) overload 2021-11-24 17:53:00 +00:00
Linus Groh
27304017e3 LibJS: Don't assume calendar was parsed in to_temporal_zoned_date_time() 
The first step of to_temporal_calendar_with_iso_default() is checking
whether the given value is undefined, so we should actually pass that
instead of unconditionally dereferencing the Optional<String>.
 2021-11-20 23:10:09 +00:00
Linus Groh
0d9defdad8 LibJS: Rename MatchBehavior members back to their old names 
I changed this in 6ef1a27 to "match the spec", but the spec calls it
`match exactly` and `match minutes` - so what we had before was correct
and the change made no sense whatsoever.
 2021-11-13 00:25:40 +00:00
Linus Groh
6ef1a2793f LibJS: Rename ZonedDateTime's MatchBehavior enum members to match spec 2021-11-10 21:27:25 +00:00
Luke Wilde
dc72d416b2 LibJS: Implement the required AOs for ZonedDateTime stringifiers 2021-11-10 12:56:56 +00:00
Linus Groh
36b51276d5 LibJS: Change calendar_date_add() date parameter from PlainDate to Value 
Turns out use of this AO is a bit more flexible than I anticipated.
 2021-11-07 15:31:28 +01:00
Luke Wilde
2b89d2a360 LibJS: Implement ToTemporalZonedDateTime and the required AOs 2021-11-07 15:35:16 +02:00
Linus Groh
d49bbb1da3 LibJS: Implement TODO()'d parts of balance_duration() 
Massive :yakstack:, so I understand why it was skipped in the first
place :^)
 2021-11-02 09:24:35 +01:00
Idan Horowitz
1822b2938e LibJS: Convert ZonedDateTime AOs to ThrowCompletionOr 2021-09-16 13:53:37 +01:00
Idan Horowitz
5a4c90fcb1 LibJS: Convert ordinary_create_from_constructor<T> to ThrowCompletionOr 2021-09-16 13:53:37 +01:00
Linus Groh
5ae6ad8557 LibJS: Store Instant's and ZonedDateTime's m_nanoseconds as a const& 
There's no need for these to be non-const. Suggested by @IdanHo in
https://github.com/SerenityOS/serenity/pull/9904#discussion_r704960184.

Perhaps we can make more internal slots of these and other objects const
references as well, but that's a bit more involved as they are used by
various functions expecting non-const references.
 2021-09-09 23:46:45 +01:00