serenity

18255 commits 1 branch 0 tags 230 MiB

Author	SHA1	Message	Date
Andreas Kling	971425d7b1	ProtocolServer: Fix null dereference in HTTP/HTTPS job finish callback The consolidation of the initialization code between HTTP and HTTPS downloads was capturing the "job" local by reference, which was not safe after we left the init() scope. Fix this by getting the HTTP::Job from the Download object instead.	2021-01-16 11:50:48 +01:00
Lenny Maiorani	7e71de8f1f	Http[s]Protocol: Make the code start_download DRY Problem: - `HttpProtocol::start_download` and `HttpsProtocol::start_download` implementations are the same except for a few types. Solution: - Follow the "Don't Repeat Yourself" mantra and de-duplicate the code using templates.	2021-01-15 09:44:21 +01:00
Andreas Kling	c7ac7e6eaf	Services: Move to Userland/Services/	2021-01-12 12:23:01 +01:00

Author

SHA1

Message

Date

Andreas Kling

971425d7b1

ProtocolServer: Fix null dereference in HTTP/HTTPS job finish callback

The consolidation of the initialization code between HTTP and HTTPS
downloads was capturing the "job" local by reference, which was not safe
after we left the init() scope.

Fix this by getting the HTTP::Job from the Download object instead.

2021-01-16 11:50:48 +01:00

Lenny Maiorani

7e71de8f1f

Http[s]Protocol: Make the code start_download DRY

Problem:
- `HttpProtocol::start_download` and `HttpsProtocol::start_download`
  implementations are the same except for a few types.

Solution:
- Follow the "Don't Repeat Yourself" mantra and de-duplicate the code
  using templates.

2021-01-15 09:44:21 +01:00

Andreas Kling

c7ac7e6eaf

Services: Move to Userland/Services/

2021-01-12 12:23:01 +01:00

Renamed from Services/ProtocolServer/HttpDownload.h (Browse further)

3 commits