mirror of
https://github.com/RGBCube/serenity
synced 2025-05-14 07:34:57 +00:00
0bf82f748f
With this change, clip rectangles for boxes with hidden overflow or the clip property are no longer calculated during the recording of painting commands. Instead, it has moved to the "pre-paint" phase, along with the assignment of scrolling offsets, and works in the following way: 1. The paintable tree is traversed to collect all paintable boxes that have hidden overflow or use the CSS clip property. For each of these boxes, the "final" clip rectangle is calculated by intersecting clip rectangles in the containing block chain for a box. 2. The paintable tree is traversed another time, and a clip rectangle is assigned for each paintable box contained by a node with hidden overflow or the clip property. This way, clipping becomes much easier during the painting commands recording phase, as it only concerns the use of already assigned clip rectangles. The same approach is applied to handle scrolling offsets. Also, clip rectangle calculation is now implemented more correctly, as we no longer stop at the stacking context boundary while intersecting clip rectangles in the containing block chain. Fixes: https://github.com/SerenityOS/serenity/issues/22932 https://github.com/SerenityOS/serenity/issues/22883 https://github.com/SerenityOS/serenity/issues/22679 https://github.com/SerenityOS/serenity/issues/22534
89 lines
3.3 KiB
C++
89 lines
3.3 KiB
C++
/*
|
|
* Copyright (c) 2018-2022, Andreas Kling <kling@serenityos.org>
|
|
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/Vector.h>
|
|
#include <LibGfx/Forward.h>
|
|
#include <LibGfx/Palette.h>
|
|
#include <LibGfx/Rect.h>
|
|
#include <LibWeb/Painting/RecordingPainter.h>
|
|
#include <LibWeb/PixelUnits.h>
|
|
|
|
namespace Web {
|
|
|
|
class PaintContext {
|
|
public:
|
|
PaintContext(Painting::RecordingPainter& painter, Palette const& palette, double device_pixels_per_css_pixel);
|
|
|
|
Painting::RecordingPainter& recording_painter() const { return m_recording_painter; }
|
|
Palette const& palette() const { return m_palette; }
|
|
|
|
bool should_show_line_box_borders() const { return m_should_show_line_box_borders; }
|
|
void set_should_show_line_box_borders(bool value) { m_should_show_line_box_borders = value; }
|
|
|
|
bool should_paint_overlay() const { return m_should_paint_overlay; }
|
|
void set_should_paint_overlay(bool should_paint_overlay) { m_should_paint_overlay = should_paint_overlay; }
|
|
|
|
DevicePixelRect device_viewport_rect() const { return m_device_viewport_rect; }
|
|
void set_device_viewport_rect(DevicePixelRect const& rect) { m_device_viewport_rect = rect; }
|
|
CSSPixelRect css_viewport_rect() const;
|
|
|
|
bool has_focus() const { return m_focus; }
|
|
void set_has_focus(bool focus) { m_focus = focus; }
|
|
|
|
void set_svg_transform(Gfx::AffineTransform transform)
|
|
{
|
|
m_svg_transform = transform;
|
|
}
|
|
|
|
Gfx::AffineTransform const& svg_transform() const
|
|
{
|
|
return m_svg_transform;
|
|
}
|
|
|
|
DevicePixels enclosing_device_pixels(CSSPixels css_pixels) const;
|
|
DevicePixels floored_device_pixels(CSSPixels css_pixels) const;
|
|
DevicePixels rounded_device_pixels(CSSPixels css_pixels) const;
|
|
DevicePixelPoint rounded_device_point(CSSPixelPoint) const;
|
|
DevicePixelPoint floored_device_point(CSSPixelPoint) const;
|
|
DevicePixelRect enclosing_device_rect(CSSPixelRect) const;
|
|
DevicePixelRect rounded_device_rect(CSSPixelRect) const;
|
|
DevicePixelSize enclosing_device_size(CSSPixelSize) const;
|
|
DevicePixelSize rounded_device_size(CSSPixelSize) const;
|
|
CSSPixels scale_to_css_pixels(DevicePixels) const;
|
|
CSSPixelPoint scale_to_css_point(DevicePixelPoint) const;
|
|
CSSPixelSize scale_to_css_size(DevicePixelSize) const;
|
|
CSSPixelRect scale_to_css_rect(DevicePixelRect) const;
|
|
|
|
PaintContext clone(Painting::RecordingPainter& painter) const
|
|
{
|
|
auto clone = PaintContext(painter, m_palette, m_device_pixels_per_css_pixel);
|
|
clone.m_device_viewport_rect = m_device_viewport_rect;
|
|
clone.m_should_show_line_box_borders = m_should_show_line_box_borders;
|
|
clone.m_should_paint_overlay = m_should_paint_overlay;
|
|
clone.m_focus = m_focus;
|
|
return clone;
|
|
}
|
|
|
|
double device_pixels_per_css_pixel() const { return m_device_pixels_per_css_pixel; }
|
|
|
|
u32 allocate_corner_clipper_id() { return m_next_corner_clipper_id++; }
|
|
|
|
private:
|
|
Painting::RecordingPainter& m_recording_painter;
|
|
Palette m_palette;
|
|
double m_device_pixels_per_css_pixel { 0 };
|
|
DevicePixelRect m_device_viewport_rect;
|
|
bool m_should_show_line_box_borders { false };
|
|
bool m_should_paint_overlay { true };
|
|
bool m_focus { false };
|
|
Gfx::AffineTransform m_svg_transform;
|
|
u32 m_next_corner_clipper_id { 0 };
|
|
};
|
|
|
|
}
|