mirror of
https://github.com/RGBCube/serenity
synced 2025-07-24 17:27:35 +00:00
96d02a3e75
Previously, a libc-like out-of-line error information was used in the loader and its plugins. Now, all functions that may fail to do their job return some sort of Result. The universally-used error type ist the new LoaderError, which can contain information about the general error category (such as file format, I/O, unimplemented features), an error description, and location information, such as file index or sample index. Additionally, the loader plugins try to do as little work as possible in their constructors. Right after being constructed, a user should call initialize() and check the errors returned from there. (This is done transparently by Loader itself.) If a constructor caused an error, the call to initialize should check and return it immediately. This opportunity was used to rework a lot of the internal error propagation in both loader classes, especially FlacLoader. Therefore, a couple of other refactorings may have sneaked in as well. The adoption of LibAudio users is minimal. Piano's adoption is not important, as the code will receive major refactoring in the near future anyways. SoundPlayer's adoption is also less important, as changes to refactor it are in the works as well. aplay's adoption is the best and may serve as an example for other users. It also includes new buffering behavior. Buffer also gets some attention, making it OOM-safe and thereby also propagating its errors to the user. |
||
|---|---|---|
| .. | ||
| BarsVisualizationWidget.cpp | ||
| BarsVisualizationWidget.h | ||
| CMakeLists.txt | ||
| Common.h | ||
| M3UParser.cpp | ||
| M3UParser.h | ||
| main.cpp | ||
| NoVisualizationWidget.cpp | ||
| NoVisualizationWidget.h | ||
| PlaybackManager.cpp | ||
| PlaybackManager.h | ||
| Player.cpp | ||
| Player.h | ||
| Playlist.cpp | ||
| Playlist.h | ||
| PlaylistWidget.cpp | ||
| PlaylistWidget.h | ||
| SampleWidget.cpp | ||
| SampleWidget.h | ||
| SoundPlayerWidgetAdvancedView.cpp | ||
| SoundPlayerWidgetAdvancedView.h | ||
| VisualizationWidget.h | ||