mirror of
https://github.com/RGBCube/serenity
synced 2026-01-21 22:10:59 +00:00
09bd5f8772
This is a huge patch, I know. In hindsight this perhaps could've been done slightly more incremental, but I started and then fixed everything until it worked, and here we are. I tried splitting of some completely unrelated changes into separate commits, however. Anyway. This is a rewrite of most of Object, and by extension large parts of Array, Proxy, Reflect, String, TypedArray, and some other things. What we already had worked fine for about 90% of things, but getting the last 10% right proved to be increasingly difficult with the current code that sort of grew organically and is only very loosely based on the spec - this became especially obvious when we started fixing a large number of test262 failures. Key changes include: - 1:1 matching function names and parameters of all object-related functions, to avoid ambiguity. Previously we had things like put(), which the spec doesn't have - as a result it wasn't always clear which need to be used. - Better separation between object abstract operations and internal methods - the former are always the same, the latter can be overridden (and are therefore virtual). The internal methods (i.e. [[Foo]] in the spec) are now prefixed with 'internal_' for clarity - again, it was previously not always clear which AO a certain method represents, get() could've been both Get and [[Get]] (I don't know which one it was closer to right now). Note that some of the old names have been kept until all code relying on them is updated, but they are now simple wrappers around the closest matching standard abstract operation. - Simplifications of the storage layer: functions that write values to storage are now prefixed with 'storage_' to make their purpose clear, and as they are not part of the spec they should not contain any steps specified by it. Much functionality is now covered by the layers above it and was removed (e.g. handling of accessors, attribute checks). - PropertyAttributes has been greatly simplified, and is being replaced by PropertyDescriptor - a concept similar to the current implementation, but more aligned with the actual spec. See the commit message of the previous commit where it was introduced for details. - As a bonus, and since I had to look at the spec a whole lot anyway, I introduced more inline comments with the exact steps from the spec - this makes it super easy to verify correctness. - East-const all the things. As a result of all of this, things are much more correct but a bit slower now. Retaining speed wasn't a consideration at all, I have done no profiling of the new code - there might be low hanging fruits, which we can then harvest separately. Special thanks to Idan for helping me with this by tracking down bugs, updating everything outside of LibJS to work with these changes (LibWeb, Spreadsheet, HackStudio), as well as providing countless patches to fix regressions I introduced - there still are very few (we got it down to 5), but we also get many new passing test262 tests in return. :^) Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com> |
||
|---|---|---|
| .. | ||
| CellType | ||
| Readers | ||
| Writers | ||
| Cell.cpp | ||
| Cell.h | ||
| CellSyntaxHighlighter.cpp | ||
| CellSyntaxHighlighter.h | ||
| CellTypeDialog.cpp | ||
| CellTypeDialog.h | ||
| CMakeLists.txt | ||
| CondFormatting.gml | ||
| ConditionalFormatting.h | ||
| CondView.gml | ||
| csv_export.gml | ||
| csv_import.gml | ||
| ExportDialog.cpp | ||
| ExportDialog.h | ||
| Forward.h | ||
| HelpWindow.cpp | ||
| HelpWindow.h | ||
| ImportDialog.cpp | ||
| ImportDialog.h | ||
| JSIntegration.cpp | ||
| JSIntegration.h | ||
| main.cpp | ||
| Position.h | ||
| select_format_page.gml | ||
| Spreadsheet.cpp | ||
| Spreadsheet.h | ||
| SpreadsheetModel.cpp | ||
| SpreadsheetModel.h | ||
| SpreadsheetView.cpp | ||
| SpreadsheetView.h | ||
| SpreadsheetWidget.cpp | ||
| SpreadsheetWidget.h | ||
| Workbook.cpp | ||
| Workbook.h | ||