mirror of
https://github.com/RGBCube/serenity
synced 2025-10-31 22:02:44 +00:00
a8a899adbf
Creating a menu/menubar needs to be synchronous because we need the ID from the response, but adding stuff *to* menus (and adding menus to menubars, and menubars to windows) can all be asynchronous. This dramatically reduces the amount of IPC ping-pong played by each GUI application during startup. I measured how long it takes TextEditor to enter the main event loop and it's over 10% faster here. (Down from ~86ms to ~74ms)
90 lines
2 KiB
C++
90 lines
2 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibGUI/Action.h>
|
|
#include <LibGUI/Menu.h>
|
|
#include <LibGUI/MenuItem.h>
|
|
#include <LibGUI/WindowServerConnection.h>
|
|
|
|
namespace GUI {
|
|
|
|
MenuItem::MenuItem(unsigned menu_id, Type type)
|
|
: m_type(type)
|
|
, m_menu_id(menu_id)
|
|
{
|
|
}
|
|
|
|
MenuItem::MenuItem(unsigned menu_id, NonnullRefPtr<Action> action)
|
|
: m_type(Type::Action)
|
|
, m_menu_id(menu_id)
|
|
, m_action(move(action))
|
|
{
|
|
m_action->register_menu_item({}, *this);
|
|
m_enabled = m_action->is_enabled();
|
|
m_checkable = m_action->is_checkable();
|
|
if (m_checkable)
|
|
m_checked = m_action->is_checked();
|
|
}
|
|
|
|
MenuItem::MenuItem(unsigned menu_id, NonnullRefPtr<Menu> submenu)
|
|
: m_type(Type::Submenu)
|
|
, m_menu_id(menu_id)
|
|
, m_submenu(move(submenu))
|
|
{
|
|
}
|
|
|
|
MenuItem::~MenuItem()
|
|
{
|
|
if (m_action)
|
|
m_action->unregister_menu_item({}, *this);
|
|
}
|
|
|
|
void MenuItem::set_enabled(bool enabled)
|
|
{
|
|
if (m_enabled == enabled)
|
|
return;
|
|
m_enabled = enabled;
|
|
update_window_server();
|
|
}
|
|
|
|
void MenuItem::set_checked(bool checked)
|
|
{
|
|
VERIFY(is_checkable());
|
|
if (m_checked == checked)
|
|
return;
|
|
m_checked = checked;
|
|
update_window_server();
|
|
}
|
|
|
|
void MenuItem::set_default(bool is_default)
|
|
{
|
|
VERIFY(is_checkable());
|
|
if (m_default == is_default)
|
|
return;
|
|
m_default = is_default;
|
|
update_window_server();
|
|
}
|
|
|
|
void MenuItem::update_window_server()
|
|
{
|
|
if (m_menu_id < 0)
|
|
return;
|
|
auto& action = *m_action;
|
|
auto shortcut_text = action.shortcut().is_valid() ? action.shortcut().to_string() : String();
|
|
WindowServerConnection::the().async_update_menu_item(m_menu_id, m_identifier, -1, action.text(), action.is_enabled(), action.is_checkable(), action.is_checkable() ? action.is_checked() : false, m_default, shortcut_text);
|
|
}
|
|
|
|
void MenuItem::set_menu_id(Badge<Menu>, unsigned int menu_id)
|
|
{
|
|
m_menu_id = menu_id;
|
|
}
|
|
|
|
void MenuItem::set_identifier(Badge<Menu>, unsigned identifier)
|
|
{
|
|
m_identifier = identifier;
|
|
}
|
|
|
|
}
|