mirror of
https://github.com/RGBCube/serenity
synced 2025-10-13 18:32:06 +00:00
e6f907a155
Problem:
- Many constructors are defined as `{}` rather than using the ` =
default` compiler-provided constructor.
- Some types provide an implicit conversion operator from `nullptr_t`
instead of requiring the caller to default construct. This violates
the C++ Core Guidelines suggestion to declare single-argument
constructors explicit
(https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c46-by-default-declare-single-argument-constructors-explicit).
Solution:
- Change default constructors to use the compiler-provided default
constructor.
- Remove implicit conversion operators from `nullptr_t` and change
usage to enforce type consistency without conversion.
|
||
|---|---|---|
| .. | ||
| ClientConnection.cpp | ||
| ClientConnection.h | ||
| CMakeLists.txt | ||
| Download.cpp | ||
| Download.h | ||
| Forward.h | ||
| GeminiDownload.cpp | ||
| GeminiDownload.h | ||
| GeminiProtocol.cpp | ||
| GeminiProtocol.h | ||
| HttpDownload.cpp | ||
| HttpDownload.h | ||
| HttpProtocol.cpp | ||
| HttpProtocol.h | ||
| HttpsDownload.cpp | ||
| HttpsDownload.h | ||
| HttpsProtocol.cpp | ||
| HttpsProtocol.h | ||
| main.cpp | ||
| Protocol.cpp | ||
| Protocol.h | ||
| ProtocolClient.ipc | ||
| ProtocolServer.ipc | ||