mirror of
https://github.com/RGBCube/serenity
synced 2025-05-31 05:38:11 +00:00
1493dd9dc6
This code was previously relying on the PageView::on_load_start hook firing synchronously when calling PageView::load(). This was not happening with WebContentView, so it broke the back/forward history. Instead, we now differentiate between history navigations and normal loads in Tab::load(). History navigations don't push new entries into history, but instead just move the history pointer.
73 lines
2.1 KiB
C++
73 lines
2.1 KiB
C++
/*
|
|
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
|
|
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "History.h"
|
|
|
|
namespace Browser {
|
|
|
|
void History::dump() const
|
|
{
|
|
dbg() << "Dump " << m_items.size() << " item(s)";
|
|
int i = 0;
|
|
for (auto& item : m_items) {
|
|
dbg() << "[" << i << "] " << item << " " << (m_current == i ? '*' : ' ');
|
|
++i;
|
|
}
|
|
}
|
|
|
|
void History::push(const URL& url)
|
|
{
|
|
m_items.shrink(m_current + 1);
|
|
m_items.append(url);
|
|
m_current++;
|
|
}
|
|
|
|
URL History::current() const
|
|
{
|
|
if (m_current == -1)
|
|
return {};
|
|
return m_items[m_current];
|
|
}
|
|
|
|
void History::go_back()
|
|
{
|
|
ASSERT(can_go_back());
|
|
m_current--;
|
|
}
|
|
|
|
void History::go_forward()
|
|
{
|
|
ASSERT(can_go_forward());
|
|
m_current++;
|
|
}
|
|
|
|
void History::clear()
|
|
{
|
|
m_items = {};
|
|
m_current = -1;
|
|
}
|
|
|
|
}
|