mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 06:32:44 +00:00 
			
		
		
		
	 1a97382305
			
		
	
	
		1a97382305
		
	
	
	
	
		
			
			The pattern to construct `Application` was to use the `try_create` method from the `C_OBJECT` macro. While being safe from an OOM perspective, this method doesn't propagate errors from the constructor. This patch make `Application` use the `C_OBJECT_ABSTRACT` and manually define a `create` method that can bubble up errors from the construction stage. This commit also removes the ability to use `argc` and `argv` to create an `Application`, only `Main`'s `Arguments` can be used. From a user point of view, the patch renames `try_create` => `create`, hence the huge number of modified files.
		
			
				
	
	
		
			69 lines
		
	
	
	
		
			2.5 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			69 lines
		
	
	
	
		
			2.5 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #include "MainWidget.h"
 | |
| #include <AK/URL.h>
 | |
| #include <LibConfig/Client.h>
 | |
| #include <LibCore/ArgsParser.h>
 | |
| #include <LibCore/System.h>
 | |
| #include <LibDesktop/Launcher.h>
 | |
| #include <LibFileSystemAccessClient/Client.h>
 | |
| #include <LibGUI/Application.h>
 | |
| #include <LibGUI/Icon.h>
 | |
| #include <LibGUI/Window.h>
 | |
| #include <LibGfx/Font/BitmapFont.h>
 | |
| #include <LibMain/Main.h>
 | |
| 
 | |
| ErrorOr<int> serenity_main(Main::Arguments arguments)
 | |
| {
 | |
|     TRY(Core::System::pledge("stdio recvfd sendfd thread rpath unix cpath wpath"));
 | |
| 
 | |
|     auto app = TRY(GUI::Application::create(arguments));
 | |
| 
 | |
|     TRY(Desktop::Launcher::add_allowed_handler_with_only_specific_urls("/bin/Help", { URL::create_with_file_scheme("/usr/share/man/man1/Applications/FontEditor.md") }));
 | |
|     TRY(Desktop::Launcher::seal_allowlist());
 | |
| 
 | |
|     Config::pledge_domain("FontEditor");
 | |
| 
 | |
|     TRY(Core::System::unveil("/tmp/session/%sid/portal/filesystemaccess", "rw"));
 | |
|     TRY(Core::System::unveil("/res", "r"));
 | |
|     TRY(Core::System::unveil(nullptr, nullptr));
 | |
| 
 | |
|     StringView path;
 | |
|     Core::ArgsParser args_parser;
 | |
|     args_parser.add_positional_argument(path, "The font file for editing.", "file", Core::ArgsParser::Required::No);
 | |
|     args_parser.parse(arguments);
 | |
| 
 | |
|     auto app_icon = TRY(GUI::Icon::try_create_default_icon("app-font-editor"sv));
 | |
| 
 | |
|     auto window = TRY(GUI::Window::try_create());
 | |
|     window->set_icon(app_icon.bitmap_for_size(16));
 | |
|     window->resize(640, 470);
 | |
| 
 | |
|     auto font_editor = TRY(window->set_main_widget<FontEditor::MainWidget>());
 | |
|     TRY(font_editor->initialize_menubar(*window));
 | |
| 
 | |
|     window->on_close_request = [&]() -> GUI::Window::CloseRequestDecision {
 | |
|         if (font_editor->request_close())
 | |
|             return GUI::Window::CloseRequestDecision::Close;
 | |
|         return GUI::Window::CloseRequestDecision::StayOpen;
 | |
|     };
 | |
| 
 | |
|     window->show();
 | |
| 
 | |
|     auto path_to_load = path.is_empty() ? "/res/fonts/KaticaRegular10.font"sv : path;
 | |
|     auto file = TRY(FileSystemAccessClient::Client::the().request_file_read_only_approved(window, path_to_load));
 | |
| 
 | |
|     if (!path.is_empty()) {
 | |
|         TRY(font_editor->open_file(file.filename(), file.release_stream()));
 | |
|     } else {
 | |
|         auto mapped_file = TRY(Core::MappedFile::map_from_file(file.release_stream(), path_to_load));
 | |
|         auto mutable_font = TRY(TRY(Gfx::BitmapFont::try_load_from_mapped_file(mapped_file))->unmasked_character_set());
 | |
|         TRY(font_editor->initialize({}, move(mutable_font)));
 | |
|     }
 | |
| 
 | |
|     return app->exec();
 | |
| }
 |