mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 09:22:44 +00:00 
			
		
		
		
	 1a97382305
			
		
	
	
		1a97382305
		
	
	
	
	
		
			
			The pattern to construct `Application` was to use the `try_create` method from the `C_OBJECT` macro. While being safe from an OOM perspective, this method doesn't propagate errors from the constructor. This patch make `Application` use the `C_OBJECT_ABSTRACT` and manually define a `create` method that can bubble up errors from the construction stage. This commit also removes the ability to use `argc` and `argv` to create an `Application`, only `Main`'s `Arguments` can be used. From a user point of view, the patch renames `try_create` => `create`, hence the huge number of modified files.
		
			
				
	
	
		
			78 lines
		
	
	
	
		
			3.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			78 lines
		
	
	
	
		
			3.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
 | |
|  * Copyright (c) 2021, networkException <networkexception@serenityos.org>
 | |
|  * Copyright (c) 2021-2022, Sam Atkins <atkinssj@serenityos.org>
 | |
|  * Copyright (c) 2021, Antonio Di Stefano <tonio9681@gmail.com>
 | |
|  * Copyright (c) 2022, Filiph Sandström <filiph.sandstrom@filfatstudios.com>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #include "MainWidget.h"
 | |
| #include <LibCore/ArgsParser.h>
 | |
| #include <LibCore/System.h>
 | |
| #include <LibFileSystem/FileSystem.h>
 | |
| #include <LibFileSystemAccessClient/Client.h>
 | |
| #include <LibGUI/Application.h>
 | |
| #include <LibGUI/Icon.h>
 | |
| #include <LibGUI/Menu.h>
 | |
| #include <LibGUI/Menubar.h>
 | |
| #include <LibGUI/MessageBox.h>
 | |
| #include <LibGUI/Window.h>
 | |
| #include <LibMain/Main.h>
 | |
| 
 | |
| ErrorOr<int> serenity_main(Main::Arguments arguments)
 | |
| {
 | |
|     TRY(Core::System::pledge("stdio recvfd sendfd thread rpath cpath wpath unix"));
 | |
| 
 | |
|     auto app = TRY(GUI::Application::create(arguments));
 | |
| 
 | |
|     StringView file_to_edit;
 | |
| 
 | |
|     Core::ArgsParser parser;
 | |
|     parser.add_positional_argument(file_to_edit, "Theme file to edit", "file", Core::ArgsParser::Required::No);
 | |
|     parser.parse(arguments);
 | |
| 
 | |
|     Optional<String> path = {};
 | |
| 
 | |
|     if (auto error_or_path = FileSystem::absolute_path(file_to_edit); !file_to_edit.is_empty() && !error_or_path.is_error())
 | |
|         path = error_or_path.release_value();
 | |
| 
 | |
|     TRY(Core::System::pledge("stdio recvfd sendfd thread rpath unix"));
 | |
|     TRY(Core::System::unveil("/tmp/session/%sid/portal/filesystemaccess", "rw"));
 | |
|     TRY(Core::System::unveil("/res", "r"));
 | |
|     TRY(Core::System::unveil(nullptr, nullptr));
 | |
| 
 | |
|     auto app_icon = GUI::Icon::default_icon("app-theme-editor"sv);
 | |
|     auto window = GUI::Window::construct();
 | |
| 
 | |
|     auto main_widget = TRY(window->set_main_widget<ThemeEditor::MainWidget>());
 | |
| 
 | |
|     if (path.has_value()) {
 | |
|         // Note: This is deferred to ensure that the window has already popped and thus proper window stealing can be performed.
 | |
|         app->event_loop().deferred_invoke(
 | |
|             [&window, &path, &main_widget]() {
 | |
|                 auto response = FileSystemAccessClient::Client::the().request_file_read_only_approved(window, path.value().to_deprecated_string());
 | |
|                 if (response.is_error())
 | |
|                     GUI::MessageBox::show_error(window, DeprecatedString::formatted("Opening \"{}\" failed: {}", path.value(), response.error()));
 | |
|                 else {
 | |
|                     auto load_from_file_result = main_widget->load_from_file(response.value().filename(), response.value().release_stream());
 | |
|                     if (load_from_file_result.is_error())
 | |
|                         GUI::MessageBox::show_error(window, DeprecatedString::formatted("Loading theme from file has failed: {}", load_from_file_result.error()));
 | |
|                 }
 | |
|             });
 | |
|     }
 | |
| 
 | |
|     TRY(main_widget->initialize_menubar(window));
 | |
|     main_widget->update_title();
 | |
| 
 | |
|     window->on_close_request = [&]() -> GUI::Window::CloseRequestDecision {
 | |
|         return main_widget->request_close();
 | |
|     };
 | |
| 
 | |
|     window->resize(820, 520);
 | |
|     window->set_resizable(false);
 | |
|     window->show();
 | |
|     window->set_icon(app_icon.bitmap_for_size(16));
 | |
|     return app->exec();
 | |
| }
 |