mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 17:37:37 +00:00
29583104d2
This commit is messy due to the Paintable and Layout classes being tangled together. The RadioButton, CheckBox and ButtonBox classes are now subclasses of FormAssociatedLabelableNode. This subclass separates these layout nodes from LabelableNode, which is also the superclass of non-form associated labelable nodes (Progress). ButtonPaintable, CheckBoxPaintable and RadioButtonPaintable no longer call events on DOM nodes directly from their mouse event handlers; instead, all the functionality is now directly in EventHandler, which dispatches the related events. handle_mousedown and related methods return a bool indicating whether the event handling should proceed. Paintable classes can now return an alternative DOM::Node which should be the target of the mouse event. Labels use this to indicate that the labeled control should be the target of the mouse events. HTMLInputElement put its activation behavior on run_activation_behavior, which wasn't actually called anywhere and had to be manually called by other places. We now use activation_behavior which is used by EventDispatcher. This commit also brings HTMLInputElement closer to spec by removing the did_foo functions that did ad-hoc event dispatching and unifies the behavior under run_input_activation_behavior. |
||
|---|---|---|
| .. | ||
| BackgroundPainting.cpp | ||
| BackgroundPainting.h | ||
| BorderPainting.cpp | ||
| BorderPainting.h | ||
| ButtonPaintable.cpp | ||
| ButtonPaintable.h | ||
| CanvasPaintable.cpp | ||
| CanvasPaintable.h | ||
| CheckBoxPaintable.cpp | ||
| CheckBoxPaintable.h | ||
| ImagePaintable.cpp | ||
| ImagePaintable.h | ||
| InlinePaintable.cpp | ||
| InlinePaintable.h | ||
| LabelablePaintable.cpp | ||
| LabelablePaintable.h | ||
| MarkerPaintable.cpp | ||
| MarkerPaintable.h | ||
| NestedBrowsingContextPaintable.cpp | ||
| NestedBrowsingContextPaintable.h | ||
| Paintable.cpp | ||
| Paintable.h | ||
| PaintableBox.cpp | ||
| PaintableBox.h | ||
| PaintContext.cpp | ||
| PaintContext.h | ||
| ProgressPaintable.cpp | ||
| ProgressPaintable.h | ||
| RadioButtonPaintable.cpp | ||
| RadioButtonPaintable.h | ||
| ShadowPainting.cpp | ||
| ShadowPainting.h | ||
| StackingContext.cpp | ||
| StackingContext.h | ||
| SVGGeometryPaintable.cpp | ||
| SVGGeometryPaintable.h | ||
| SVGGraphicsPaintable.cpp | ||
| SVGGraphicsPaintable.h | ||
| SVGPaintable.cpp | ||
| SVGPaintable.h | ||
| SVGSVGPaintable.cpp | ||
| SVGSVGPaintable.h | ||
| TextPaintable.cpp | ||
| TextPaintable.h | ||