mirror of
https://github.com/RGBCube/serenity
synced 2025-05-20 14:55:08 +00:00

The result of a SQL statement execution is either: 1. An error. 2. The list of rows inserted, deleted, selected, etc. (2) is currently represented by a combination of the Result class and the ResultSet list it holds. This worked okay, but issues start to arise when trying to use Result in non-statement contexts (for example, when introducing Result to SQL expression execution). What we really need is for Result to be a thin wrapper that represents both (1) and (2), and to not have any explicit members like a ResultSet. So this commit removes ResultSet from Result, and introduces ResultOr, which is just an alias for AK::ErrorOrr. Statement execution now returns ResultOr<ResultSet> instead of Result. This further opens the door for expression execution to return ResultOr<Value> in the future. Lastly, this moves some other context held by Result over to ResultSet. This includes the row count (which is really just the size of ResultSet) and the command for which the result is for.
141 lines
4.2 KiB
C++
141 lines
4.2 KiB
C++
/*
|
|
* Copyright (c) 2021, Jan de Visser <jan@de-visser.net>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibCore/Object.h>
|
|
#include <LibSQL/AST/Parser.h>
|
|
#include <SQLServer/ClientConnection.h>
|
|
#include <SQLServer/DatabaseConnection.h>
|
|
#include <SQLServer/SQLStatement.h>
|
|
|
|
namespace SQLServer {
|
|
|
|
static HashMap<int, NonnullRefPtr<SQLStatement>> s_statements;
|
|
|
|
RefPtr<SQLStatement> SQLStatement::statement_for(int statement_id)
|
|
{
|
|
if (s_statements.contains(statement_id))
|
|
return *s_statements.get(statement_id).value();
|
|
dbgln_if(SQLSERVER_DEBUG, "Invalid statement_id {}", statement_id);
|
|
return nullptr;
|
|
}
|
|
|
|
static int s_next_statement_id = 0;
|
|
|
|
SQLStatement::SQLStatement(DatabaseConnection& connection, String sql)
|
|
: Core::Object(&connection)
|
|
, m_statement_id(s_next_statement_id++)
|
|
, m_sql(move(sql))
|
|
{
|
|
dbgln_if(SQLSERVER_DEBUG, "SQLStatement({}, {})", connection.connection_id(), sql);
|
|
s_statements.set(m_statement_id, *this);
|
|
}
|
|
|
|
void SQLStatement::report_error(SQL::Result result)
|
|
{
|
|
dbgln_if(SQLSERVER_DEBUG, "SQLStatement::report_error(statement_id {}, error {}", statement_id(), result.error_string());
|
|
|
|
auto client_connection = ClientConnection::client_connection_for(connection()->client_id());
|
|
|
|
s_statements.remove(statement_id());
|
|
remove_from_parent();
|
|
|
|
if (client_connection)
|
|
client_connection->async_execution_error(statement_id(), (int)result.error(), result.error_string());
|
|
else
|
|
warnln("Cannot return execution error. Client disconnected");
|
|
|
|
m_statement = nullptr;
|
|
m_result = {};
|
|
}
|
|
|
|
void SQLStatement::execute()
|
|
{
|
|
dbgln_if(SQLSERVER_DEBUG, "SQLStatement::execute(statement_id {}", statement_id());
|
|
auto client_connection = ClientConnection::client_connection_for(connection()->client_id());
|
|
if (!client_connection) {
|
|
warnln("Cannot yield next result. Client disconnected");
|
|
return;
|
|
}
|
|
|
|
deferred_invoke([this]() mutable {
|
|
auto parse_result = parse();
|
|
if (parse_result.is_error()) {
|
|
report_error(parse_result.release_error());
|
|
return;
|
|
}
|
|
|
|
VERIFY(!connection()->database().is_null());
|
|
|
|
auto execution_result = m_statement->execute(connection()->database().release_nonnull());
|
|
if (execution_result.is_error()) {
|
|
report_error(execution_result.release_error());
|
|
return;
|
|
}
|
|
|
|
auto client_connection = ClientConnection::client_connection_for(connection()->client_id());
|
|
if (!client_connection) {
|
|
warnln("Cannot return statement execution results. Client disconnected");
|
|
return;
|
|
}
|
|
|
|
m_result = execution_result.release_value();
|
|
|
|
if (should_send_result_rows()) {
|
|
client_connection->async_execution_success(statement_id(), true, 0, 0, 0);
|
|
m_index = 0;
|
|
next();
|
|
} else {
|
|
client_connection->async_execution_success(statement_id(), false, 0, m_result->size(), 0);
|
|
}
|
|
});
|
|
}
|
|
|
|
SQL::ResultOr<void> SQLStatement::parse()
|
|
{
|
|
auto parser = SQL::AST::Parser(SQL::AST::Lexer(m_sql));
|
|
m_statement = parser.next_statement();
|
|
|
|
if (parser.has_errors())
|
|
return SQL::Result { SQL::SQLCommand::Unknown, SQL::SQLErrorCode::SyntaxError, parser.errors()[0].to_string() };
|
|
return {};
|
|
}
|
|
|
|
bool SQLStatement::should_send_result_rows() const
|
|
{
|
|
VERIFY(m_result.has_value());
|
|
|
|
if (m_result->is_empty())
|
|
return false;
|
|
|
|
switch (m_result->command()) {
|
|
case SQL::SQLCommand::Describe:
|
|
case SQL::SQLCommand::Select:
|
|
return true;
|
|
default:
|
|
return false;
|
|
}
|
|
}
|
|
|
|
void SQLStatement::next()
|
|
{
|
|
VERIFY(!m_result->is_empty());
|
|
auto client_connection = ClientConnection::client_connection_for(connection()->client_id());
|
|
if (!client_connection) {
|
|
warnln("Cannot yield next result. Client disconnected");
|
|
return;
|
|
}
|
|
if (m_index < m_result->size()) {
|
|
auto& tuple = m_result->at(m_index++).row;
|
|
client_connection->async_next_result(statement_id(), tuple.to_string_vector());
|
|
deferred_invoke([this]() {
|
|
next();
|
|
});
|
|
} else {
|
|
client_connection->async_results_exhausted(statement_id(), (int)m_index);
|
|
}
|
|
}
|
|
|
|
}
|