mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 09:12:45 +00:00 
			
		
		
		
	 aee4786d8e
			
		
	
	
		aee4786d8e
		
	
	
	
	
		
			
			This singleton simplifies many aspects that we struggled with before: 1. There's no need to make derived classes of Device expose the constructor as public anymore. The singleton is a friend of them, so he can call the constructor. This solves the issue with try_create_device helper neatly, hopefully for good. 2. Getting a reference of the NullDevice is now being done from this singleton, which means that NullDevice no longer needs to use its own singleton, and we can apply the try_create_device helper on it too :) 3. We can now defer registration completely after the Device constructor which means the Device constructor is merely assigning the major and minor numbers of the Device, and the try_create_device helper ensures it calls the after_inserting method immediately after construction. This creates a great opportunity to make registration more OOM-safe.
		
			
				
	
	
		
			44 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			44 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2021, Liav A. <liavalb@hotmail.co.il>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <Kernel/Interrupts/IRQHandler.h>
 | |
| #include <Kernel/Locking/Mutex.h>
 | |
| #include <Kernel/Storage/AHCIPort.h>
 | |
| #include <Kernel/Storage/StorageDevice.h>
 | |
| 
 | |
| namespace Kernel {
 | |
| 
 | |
| class AHCIController;
 | |
| class SATADiskDevice final : public StorageDevice {
 | |
|     friend class AHCIController;
 | |
|     friend class DeviceManagement;
 | |
| 
 | |
| public:
 | |
|     enum class InterfaceType : u8 {
 | |
|         SATA,
 | |
|         SATAPI,
 | |
|     };
 | |
| 
 | |
| public:
 | |
|     static NonnullRefPtr<SATADiskDevice> create(const AHCIController&, const AHCIPort&, size_t sector_size, u64 max_addressable_block);
 | |
|     virtual ~SATADiskDevice() override;
 | |
| 
 | |
|     // ^StorageDevice
 | |
|     // ^BlockDevice
 | |
|     virtual void start_request(AsyncBlockDeviceRequest&) override;
 | |
|     virtual String storage_name() const override;
 | |
| 
 | |
| private:
 | |
|     SATADiskDevice(const AHCIController&, const AHCIPort&, size_t sector_size, u64 max_addressable_block);
 | |
| 
 | |
|     // ^DiskDevice
 | |
|     virtual StringView class_name() const override;
 | |
|     WeakPtr<AHCIPort> m_port;
 | |
| };
 | |
| 
 | |
| }
 |