mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 01:22:43 +00:00 
			
		
		
		
	 02a95a196f
			
		
	
	
		02a95a196f
		
	
	
	
	
		
			
			This patch stops using VirtualRangeAllocator in AddressSpace and instead looks for holes in the region tree when allocating VM space. There are many benefits: - VirtualRangeAllocator is non-intrusive and would call kmalloc/kfree when used. This new solution is allocation-free. This was a source of unpleasant MM/kmalloc deadlocks. - We consolidate authority on what the address space looks like in a single place. Previously, we had both the range allocator *and* the region tree both being used to determine if an address was valid. Now there is only the region tree. - Deallocation of VM when splitting regions is no longer complicated, as we don't need to keep two separate trees in sync.
		
			
				
	
	
		
			61 lines
		
	
	
	
		
			1.6 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			61 lines
		
	
	
	
		
			1.6 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
 | |
|  * Copyright (c) 2021, Leon Albrecht <leon2002.la@gmail.com>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #include <AK/Vector.h>
 | |
| #include <Kernel/Memory/MemoryManager.h>
 | |
| #include <Kernel/Memory/VirtualRange.h>
 | |
| #include <LibC/limits.h>
 | |
| 
 | |
| namespace Kernel::Memory {
 | |
| 
 | |
| Vector<VirtualRange, 2> VirtualRange::carve(VirtualRange const& taken) const
 | |
| {
 | |
|     VERIFY((taken.size() % PAGE_SIZE) == 0);
 | |
| 
 | |
|     Vector<VirtualRange, 2> parts;
 | |
|     if (taken == *this)
 | |
|         return {};
 | |
|     if (taken.base() > base())
 | |
|         parts.append({ base(), taken.base().get() - base().get() });
 | |
|     if (taken.end() < end())
 | |
|         parts.append({ taken.end(), end().get() - taken.end().get() });
 | |
|     return parts;
 | |
| }
 | |
| 
 | |
| bool VirtualRange::intersects(VirtualRange const& other) const
 | |
| {
 | |
|     auto a = *this;
 | |
|     auto b = other;
 | |
| 
 | |
|     if (a.base() > b.base())
 | |
|         swap(a, b);
 | |
| 
 | |
|     return a.base() < b.end() && b.base() < a.end();
 | |
| }
 | |
| 
 | |
| VirtualRange VirtualRange::intersect(VirtualRange const& other) const
 | |
| {
 | |
|     if (*this == other) {
 | |
|         return *this;
 | |
|     }
 | |
|     auto new_base = max(base(), other.base());
 | |
|     auto new_end = min(end(), other.end());
 | |
|     VERIFY(new_base < new_end);
 | |
|     return VirtualRange(new_base, (new_end - new_base).get());
 | |
| }
 | |
| 
 | |
| ErrorOr<VirtualRange> VirtualRange::expand_to_page_boundaries(FlatPtr address, size_t size)
 | |
| {
 | |
|     if ((address + size) < address)
 | |
|         return EINVAL;
 | |
| 
 | |
|     auto base = VirtualAddress { address }.page_base();
 | |
|     auto end = TRY(page_round_up(address + size));
 | |
|     return VirtualRange { base, end - base.get() };
 | |
| }
 | |
| 
 | |
| }
 |