1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-15 06:14:58 +00:00
serenity/Userland/Libraries/LibWeb/SVG/SVGUseElement.h
MacDue 720c27efbd LibWeb: Ensure transform of SVG <use> updates with x and y attributes
Rather than modify the transform of the parent (which could change
independently), this adds a new override element_transform() where
element specific tranfroms can be applied. This will always stay in
sync with the attributes.

A ref test comparing a .svg and .html version of the same file is
added as due to differences in attribute parsing order, the .svg version
was previously drawn incorrectly.

Fixes #20859
2023-08-31 11:10:30 +02:00

71 lines
2 KiB
C++

/*
* Copyright (c) 2023, Preston Taylor <95388976+PrestonLTaylor@users.noreply.github.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <LibGfx/Path.h>
#include <LibWeb/DOM/DocumentObserver.h>
#include <LibWeb/SVG/SVGAnimatedLength.h>
#include <LibWeb/SVG/SVGGraphicsElement.h>
namespace Web::SVG {
class SVGUseElement final : public SVGGraphicsElement {
WEB_PLATFORM_OBJECT(SVGUseElement, SVGGraphicsElement);
public:
virtual ~SVGUseElement() override = default;
virtual void attribute_changed(DeprecatedFlyString const& name, DeprecatedString const& value) override;
virtual void inserted() override;
void svg_element_changed(SVGElement&);
void svg_element_removed(SVGElement&);
JS::NonnullGCPtr<SVGAnimatedLength> x() const;
JS::NonnullGCPtr<SVGAnimatedLength> y() const;
JS::NonnullGCPtr<SVGAnimatedLength> width() const;
JS::NonnullGCPtr<SVGAnimatedLength> height() const;
JS::GCPtr<SVGElement> instance_root() const;
JS::GCPtr<SVGElement> animated_instance_root() const;
virtual Gfx::AffineTransform element_transform() const override;
private:
SVGUseElement(DOM::Document&, DOM::QualifiedName);
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
virtual bool is_svg_use_element() const override { return true; }
virtual JS::GCPtr<Layout::Node> create_layout_node(NonnullRefPtr<CSS::StyleProperties>) override;
Optional<StringView> parse_id_from_href(DeprecatedString const& href);
JS::GCPtr<DOM::Element> referenced_element();
void clone_element_tree_as_our_shadow_tree(Element* to_clone) const;
bool is_valid_reference_element(Element* reference_element) const;
Optional<float> m_x;
Optional<float> m_y;
Optional<StringView> m_referenced_id;
JS::GCPtr<DOM::DocumentObserver> m_document_observer;
};
}
namespace Web::DOM {
template<>
inline bool Node::fast_is<SVG::SVGUseElement>() const { return is_svg_use_element(); }
}