mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 14:02:46 +00:00 
			
		
		
		
	 41a3c19cfe
			
		
	
	
		41a3c19cfe
		
	
	
	
	
		
			
			This change fixes GC-leak caused by following mutual dependency: - SVGDecodedImageData owns JS::Handle for Page. - SVGDecodedImageData is owned by visited objects. by making everything inherited from HTML::DecodedImageData and ListOfAvailableImages to be GC-allocated. Generally, if visited object has a handle, very likely we leak everything visited from object in a handle.
		
			
				
	
	
		
			59 lines
		
	
	
	
		
			1.7 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			59 lines
		
	
	
	
		
			1.7 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2023, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #include <LibGfx/Bitmap.h>
 | |
| #include <LibJS/Heap/Heap.h>
 | |
| #include <LibJS/Runtime/Realm.h>
 | |
| #include <LibWeb/HTML/AnimatedBitmapDecodedImageData.h>
 | |
| 
 | |
| namespace Web::HTML {
 | |
| 
 | |
| JS_DEFINE_ALLOCATOR(AnimatedBitmapDecodedImageData);
 | |
| 
 | |
| ErrorOr<JS::NonnullGCPtr<AnimatedBitmapDecodedImageData>> AnimatedBitmapDecodedImageData::create(JS::Realm& realm, Vector<Frame>&& frames, size_t loop_count, bool animated)
 | |
| {
 | |
|     return realm.heap().allocate<AnimatedBitmapDecodedImageData>(realm, move(frames), loop_count, animated);
 | |
| }
 | |
| 
 | |
| AnimatedBitmapDecodedImageData::AnimatedBitmapDecodedImageData(Vector<Frame>&& frames, size_t loop_count, bool animated)
 | |
|     : m_frames(move(frames))
 | |
|     , m_loop_count(loop_count)
 | |
|     , m_animated(animated)
 | |
| {
 | |
| }
 | |
| 
 | |
| AnimatedBitmapDecodedImageData::~AnimatedBitmapDecodedImageData() = default;
 | |
| 
 | |
| RefPtr<Gfx::ImmutableBitmap> AnimatedBitmapDecodedImageData::bitmap(size_t frame_index, Gfx::IntSize) const
 | |
| {
 | |
|     if (frame_index >= m_frames.size())
 | |
|         return nullptr;
 | |
|     return m_frames[frame_index].bitmap;
 | |
| }
 | |
| 
 | |
| int AnimatedBitmapDecodedImageData::frame_duration(size_t frame_index) const
 | |
| {
 | |
|     if (frame_index >= m_frames.size())
 | |
|         return 0;
 | |
|     return m_frames[frame_index].duration;
 | |
| }
 | |
| 
 | |
| Optional<CSSPixels> AnimatedBitmapDecodedImageData::intrinsic_width() const
 | |
| {
 | |
|     return m_frames.first().bitmap->width();
 | |
| }
 | |
| 
 | |
| Optional<CSSPixels> AnimatedBitmapDecodedImageData::intrinsic_height() const
 | |
| {
 | |
|     return m_frames.first().bitmap->height();
 | |
| }
 | |
| 
 | |
| Optional<CSSPixelFraction> AnimatedBitmapDecodedImageData::intrinsic_aspect_ratio() const
 | |
| {
 | |
|     return CSSPixels(m_frames.first().bitmap->width()) / CSSPixels(m_frames.first().bitmap->height());
 | |
| }
 | |
| 
 | |
| }
 |