mirror of
https://github.com/RGBCube/serenity
synced 2025-05-16 19:05:08 +00:00

Previously, we stored a RefPtr to the HackStudioWidget in the global scope. This led to a destruction-order related use-after-free bug, where the global HackStudioWidget instance destructed after the static-local GUI::Clipboard instance. When HackStudioWidget destructs it attempts to use the global Clipboard instance, which had already been freed. This caused the Hack Studio process to spin endlessly on exit because it attempted to access the HashTable of the freed Clipboard object. We now store a global WeakPtr to the HackStudioWidget instead, and limit the lifetime of the object to the main function scope.
182 lines
5.3 KiB
C++
182 lines
5.3 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include "Editor.h"
|
|
#include "HackStudio.h"
|
|
#include "HackStudioWidget.h"
|
|
#include "Project.h"
|
|
#include <AK/StringBuilder.h>
|
|
#include <LibConfig/Client.h>
|
|
#include <LibCore/ArgsParser.h>
|
|
#include <LibCore/File.h>
|
|
#include <LibCore/System.h>
|
|
#include <LibGUI/Application.h>
|
|
#include <LibGUI/Menubar.h>
|
|
#include <LibGUI/Notification.h>
|
|
#include <LibGUI/Window.h>
|
|
#include <LibMain/Main.h>
|
|
#include <fcntl.h>
|
|
#include <spawn.h>
|
|
#include <stdio.h>
|
|
#include <sys/types.h>
|
|
#include <sys/wait.h>
|
|
#include <unistd.h>
|
|
|
|
using namespace HackStudio;
|
|
|
|
static WeakPtr<HackStudioWidget> s_hack_studio_widget;
|
|
|
|
static bool make_is_available();
|
|
static void notify_make_not_available();
|
|
static void update_path_environment_variable();
|
|
|
|
ErrorOr<int> serenity_main(Main::Arguments arguments)
|
|
{
|
|
TRY(Core::System::pledge("stdio recvfd sendfd tty rpath cpath wpath proc exec unix fattr thread ptrace"));
|
|
|
|
auto app = GUI::Application::construct(arguments.argc, arguments.argv);
|
|
Config::pledge_domains({ "HackStudio", "Terminal" });
|
|
|
|
auto window = GUI::Window::construct();
|
|
window->resize(840, 600);
|
|
window->set_icon(Gfx::Bitmap::try_load_from_file("/res/icons/16x16/app-hack-studio.png").release_value_but_fixme_should_propagate_errors());
|
|
|
|
update_path_environment_variable();
|
|
|
|
if (!make_is_available()) {
|
|
notify_make_not_available();
|
|
}
|
|
|
|
const char* path_argument = nullptr;
|
|
bool mode_coredump = false;
|
|
Core::ArgsParser args_parser;
|
|
args_parser.add_positional_argument(path_argument, "Path to a workspace or a file", "path", Core::ArgsParser::Required::No);
|
|
args_parser.add_option(mode_coredump, "Debug a coredump in HackStudio", "coredump", 'c');
|
|
args_parser.parse(arguments);
|
|
|
|
auto argument_absolute_path = Core::File::real_path_for(path_argument);
|
|
|
|
auto project_path = argument_absolute_path;
|
|
if (argument_absolute_path.is_null() || mode_coredump)
|
|
project_path = Core::File::real_path_for(".");
|
|
|
|
auto hack_studio_widget = TRY(window->try_set_main_widget<HackStudioWidget>(project_path));
|
|
s_hack_studio_widget = hack_studio_widget;
|
|
|
|
window->set_title(String::formatted("{} - Hack Studio", hack_studio_widget->project().name()));
|
|
|
|
hack_studio_widget->initialize_menubar(*window);
|
|
|
|
window->on_close_request = [&]() -> GUI::Window::CloseRequestDecision {
|
|
hack_studio_widget->locator().close();
|
|
if (hack_studio_widget->warn_unsaved_changes("There are unsaved changes, do you want to save before exiting?") == HackStudioWidget::ContinueDecision::Yes)
|
|
return GUI::Window::CloseRequestDecision::Close;
|
|
return GUI::Window::CloseRequestDecision::StayOpen;
|
|
};
|
|
|
|
window->show();
|
|
hack_studio_widget->update_actions();
|
|
|
|
if (mode_coredump)
|
|
hack_studio_widget->open_coredump(argument_absolute_path);
|
|
|
|
return app->exec();
|
|
}
|
|
|
|
static bool make_is_available()
|
|
{
|
|
pid_t pid;
|
|
const char* argv[] = { "make", "--version", nullptr };
|
|
posix_spawn_file_actions_t action;
|
|
posix_spawn_file_actions_init(&action);
|
|
posix_spawn_file_actions_addopen(&action, STDOUT_FILENO, "/dev/null", O_WRONLY, 0);
|
|
|
|
if ((errno = posix_spawnp(&pid, "make", &action, nullptr, const_cast<char**>(argv), environ))) {
|
|
perror("posix_spawn");
|
|
return false;
|
|
}
|
|
int wstatus;
|
|
waitpid(pid, &wstatus, 0);
|
|
posix_spawn_file_actions_destroy(&action);
|
|
return WEXITSTATUS(wstatus) == 0;
|
|
}
|
|
|
|
static void notify_make_not_available()
|
|
{
|
|
auto notification = GUI::Notification::construct();
|
|
notification->set_icon(Gfx::Bitmap::try_load_from_file("/res/icons/32x32/app-hack-studio.png").release_value_but_fixme_should_propagate_errors());
|
|
notification->set_title("'make' Not Available");
|
|
notification->set_text("You probably want to install the binutils, gcc, and make ports from the root of the Serenity repository");
|
|
notification->show();
|
|
}
|
|
|
|
static void update_path_environment_variable()
|
|
{
|
|
StringBuilder path;
|
|
path.append(getenv("PATH"));
|
|
if (path.length())
|
|
path.append(":");
|
|
path.append("/usr/local/bin:/usr/bin:/bin");
|
|
setenv("PATH", path.to_string().characters(), true);
|
|
}
|
|
|
|
namespace HackStudio {
|
|
|
|
GUI::TextEditor& current_editor()
|
|
{
|
|
return s_hack_studio_widget->current_editor();
|
|
}
|
|
|
|
void open_file(const String& filename)
|
|
{
|
|
s_hack_studio_widget->open_file(filename);
|
|
}
|
|
|
|
void open_file(const String& filename, size_t line, size_t column)
|
|
{
|
|
s_hack_studio_widget->open_file(filename, line, column);
|
|
}
|
|
|
|
RefPtr<EditorWrapper> current_editor_wrapper()
|
|
{
|
|
if (!s_hack_studio_widget)
|
|
return nullptr;
|
|
return s_hack_studio_widget->current_editor_wrapper();
|
|
}
|
|
|
|
Project& project()
|
|
{
|
|
return s_hack_studio_widget->project();
|
|
}
|
|
|
|
String currently_open_file()
|
|
{
|
|
if (!s_hack_studio_widget)
|
|
return {};
|
|
return s_hack_studio_widget->active_file();
|
|
}
|
|
|
|
void set_current_editor_wrapper(RefPtr<EditorWrapper> wrapper)
|
|
{
|
|
s_hack_studio_widget->set_current_editor_wrapper(wrapper);
|
|
}
|
|
|
|
Locator& locator()
|
|
{
|
|
return s_hack_studio_widget->locator();
|
|
}
|
|
|
|
void for_each_open_file(Function<void(ProjectFile const&)> func)
|
|
{
|
|
s_hack_studio_widget->for_each_open_file(move(func));
|
|
}
|
|
|
|
bool semantic_syntax_highlighting_is_enabled()
|
|
{
|
|
return s_hack_studio_widget->semantic_syntax_highlighting_is_enabled();
|
|
}
|
|
|
|
}
|