RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:48:11 +00:00
Code Issues Activity Actions
serenity/Userland/Libraries/LibWeb/CSS
History
Vetrox 5080126095 LibWeb: CSS don't set resolve-failures (var/attr) 
Previously when resolving an attr or var-defined property
with a 'not-set' value like this `property: var(--ValueNotSet)`,
we left the property unchanged (as an unresolved) and
added it to the computed-style of the element.
We still don't change the property but rather we now also don't set
unresolved properties in the computed-style.
This is an intended behavior.

The specification suggests that, on resolving an attr or var property
(custom properties) we have an invalid property when neither the
variable inside the var, nor the backup value could be resolved.

An invalid property must be inherited or defaulted depending on it's
type. We already do this with every 'untouched'
(as in m_property_values contains no entry for it) value.
So not setting the property results in an inherited (or initial)
value by a later-called function.

This also fixes another problem, where
`text-decoration: var(--NotSet)`
wouldn't be inherited because the computed-style of the
parent element hasn't set `text-decoration` but rather
all it's long-versions like `text-decoration-line` and so on.
2023-01-03 18:07:28 +01:00
..
Parser LibWeb: Support calc() values in background-position 2022-12-11 22:09:24 +01:00
SyntaxHighlighter LibSyntax: Teach each highlighter about it's comment syntax 2022-11-27 18:28:43 -07:00
Angle.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Angle.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
BackdropFilter.h LibWeb: Plumb style/computed values for backdrop-filter 2022-09-16 10:50:48 +01:00
Clip.cpp LibWeb: Use rect value in CSS clip property 2022-08-07 22:40:11 +02:00
Clip.h LibWeb: Use rect value in CSS clip property 2022-08-07 22:40:11 +02:00
ComputedValues.h Meta+Userland: Pass Gfx::Color by value 2022-12-07 11:48:27 +01:00
CSSConditionRule.cpp LibWeb: Remove unecessary dependence on Window from CSS classes 2022-10-01 21:05:32 +01:00
CSSConditionRule.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
CSSConditionRule.idl LibWeb: Remove the NoInstanceWrapper extended IDL attribute 2022-09-06 00:27:09 +02:00
CSSFontFaceRule.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
CSSFontFaceRule.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
CSSFontFaceRule.idl LibWeb: Remove the NoInstanceWrapper extended IDL attribute 2022-09-06 00:27:09 +02:00
CSSGroupingRule.cpp LibWeb: Remove unecessary dependence on Window from CSS classes 2022-10-01 21:05:32 +01:00
CSSGroupingRule.h LibWeb: Remove unecessary dependence on Window from CSS classes 2022-10-01 21:05:32 +01:00
CSSGroupingRule.idl LibWeb: Remove the NoInstanceWrapper extended IDL attribute 2022-09-06 00:27:09 +02:00
CSSImportRule.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
CSSImportRule.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
CSSImportRule.idl LibWeb: Remove the NoInstanceWrapper extended IDL attribute 2022-09-06 00:27:09 +02:00
CSSMediaRule.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
CSSMediaRule.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
CSSMediaRule.idl LibWeb: Remove the NoInstanceWrapper extended IDL attribute 2022-09-06 00:27:09 +02:00
CSSRule.cpp AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
CSSRule.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
CSSRule.idl LibWeb: Remove the NoInstanceWrapper extended IDL attribute 2022-09-06 00:27:09 +02:00
CSSRuleList.cpp LibJS: Convert Heap::allocate{,_without_realm}() to NonnullGCPtr 2022-12-15 06:56:37 -05:00
CSSRuleList.h LibWeb: Remove unecessary dependence on Window from CSS classes 2022-10-01 21:05:32 +01:00
CSSRuleList.idl LibWeb: Remove the NoInstanceWrapper extended IDL attribute 2022-09-06 00:27:09 +02:00
CSSStyleDeclaration.cpp LibJS: Replace standalone js_string() with PrimitiveString::create() 2022-12-07 16:43:06 +00:00
CSSStyleDeclaration.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
CSSStyleDeclaration.idl LibWeb: Implement CSSStyleDeclaration.cssText 2022-11-07 14:10:41 +01:00
CSSStyleRule.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
CSSStyleRule.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
CSSStyleRule.idl LibWeb: Remove the NoInstanceWrapper extended IDL attribute 2022-09-06 00:27:09 +02:00
CSSStyleSheet.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
CSSStyleSheet.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
CSSStyleSheet.idl LibWeb: Add Exposed attribute and IDL spec links where missing 2022-10-09 10:14:57 +02:00
CSSSupportsRule.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
CSSSupportsRule.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
CSSSupportsRule.idl LibWeb: Remove the NoInstanceWrapper extended IDL attribute 2022-09-06 00:27:09 +02:00
Default.css LibWeb: Support displaying HTMLInputElement placeholder values 2022-12-01 11:18:11 -05:00
Display.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Display.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Enums.json LibWeb: Parse the CSS align-content property 2022-10-14 19:50:15 +02:00
FontFace.cpp LibWeb: Parse @font-face unicode-range descriptor 2022-04-07 21:20:14 +02:00
FontFace.h LibWeb: Understand the format() part of a @font-face's src 2022-04-07 21:20:14 +02:00
Frequency.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Frequency.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
GeneralEnclosed.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
GridTrackPlacement.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
GridTrackPlacement.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
GridTrackSize.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
GridTrackSize.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Identifiers.json LibWeb: Teach CSS::StyleProperties to create CSS::Size values 2022-09-25 17:51:43 +02:00
Length.cpp LibWeb: Allow creating Lengths from CSSPixels 2022-12-10 12:03:19 +00:00
Length.h LibWeb: Allow creating Lengths from CSSPixels 2022-12-10 12:03:19 +00:00
LengthBox.cpp LibWeb: Resolve cyclic declaration/definitions involving Length 2022-09-15 14:45:38 +01:00
LengthBox.h LibWeb: Resolve cyclic declaration/definitions involving Length 2022-09-15 14:45:38 +01:00
LinkStyle.idl LibWeb: Extract the LinkStyle IDL mixin 2022-07-29 17:15:49 +01:00
MediaFeatures.json LibWeb: Add missing MEDIAQUERIES-5 media-features 2022-03-16 22:07:53 +01:00
MediaList.cpp LibJS: Replace standalone js_string() with PrimitiveString::create() 2022-12-07 16:43:06 +00:00
MediaList.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
MediaList.idl LibWeb: Remove the NoInstanceWrapper extended IDL attribute 2022-09-06 00:27:09 +02:00
MediaQuery.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
MediaQuery.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
MediaQueryList.cpp LibJS: Convert Heap::allocate{,_without_realm}() to NonnullGCPtr 2022-12-15 06:56:37 -05:00
MediaQueryList.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
MediaQueryList.idl LibWeb: Replace ad-hoc EventHandler type with callback function typedef 2022-03-31 01:10:47 +02:00
MediaQueryListEvent.cpp LibWeb: Remove unecessary dependence on Window from CSS classes 2022-10-01 21:05:32 +01:00
MediaQueryListEvent.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
MediaQueryListEvent.idl LibWeb: Add Exposed attribute and IDL spec links where missing 2022-10-09 10:14:57 +02:00
Number.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Percentage.cpp LibWeb: Stop handling impossible Percentage return values 2022-07-21 16:36:08 +02:00
Percentage.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
PreferredColorScheme.cpp AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
PreferredColorScheme.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
Properties.json LibWeb: Mark the border-style properties as layout affecting 2022-12-31 23:22:02 +01:00
QuirksMode.css LibWeb: Flesh out the default "quirks mode" style sheet 2022-09-20 14:48:07 +02:00
Ratio.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Ratio.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Resolution.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Resolution.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
ResolvedCSSStyleDeclaration.cpp LibWeb: Use HashMap::try_ensure_capacity in StyleComputer 2022-12-10 14:29:46 +01:00
ResolvedCSSStyleDeclaration.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
Screen.cpp LibJS: Convert Heap::allocate{,_without_realm}() to NonnullGCPtr 2022-12-15 06:56:37 -05:00
Screen.h LibWeb: Remove unecessary dependence on Window from CSS classes 2022-10-01 21:05:32 +01:00
Screen.idl LibWeb: Add Exposed attribute and IDL spec links where missing 2022-10-09 10:14:57 +02:00
Selector.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Selector.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
SelectorEngine.cpp LibWeb: Apply :enabled pseudo class to only certain elements 2022-09-30 21:46:53 +02:00
SelectorEngine.h LibWeb: Match styles for pseudo-elements 2022-02-25 19:35:34 +01:00
Serialize.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Serialize.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
Size.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Size.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
StyleComputer.cpp LibWeb: CSS don't set resolve-failures (var/attr) 2023-01-03 18:07:28 +01:00
StyleComputer.h LibWeb: Use HashMap::try_ensure_capacity in StyleComputer 2022-12-10 14:29:46 +01:00
StyleProperties.cpp LibWeb: Allow use of calculated property for line-height 2023-01-01 18:38:01 +01:00
StyleProperties.h LibWeb: Remove unused StyleProperties::length_or_fallback function 2022-12-10 11:46:12 +00:00
StyleSheet.cpp LibWeb: Respect media attribute of style tag 2022-11-14 14:47:37 +00:00
StyleSheet.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
StyleSheet.idl LibWeb: Respect media attribute of style tag 2022-11-14 14:47:37 +00:00
StyleSheetList.cpp LibWeb: Don't invalidate style when adding/removing empty style sheet 2022-10-29 15:16:57 +02:00
StyleSheetList.h LibWeb: Remove WRAPPER_HACK() macro 2022-09-21 21:12:24 +01:00
StyleSheetList.idl LibWeb: Remove the NoInstanceWrapper extended IDL attribute 2022-09-06 00:27:09 +02:00
StyleValue.cpp LibWeb: Fix passing size/position to paint_radial_gradient() 2022-12-20 11:03:18 +01:00
StyleValue.h Meta+Userland: Pass Gfx::FloatSize by value 2022-12-07 11:48:27 +01:00
Supports.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Supports.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Time.cpp Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
Time.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00
TransformFunctions.json LibWeb: Support translate3d 2022-11-02 11:04:23 +00:00
UnicodeRange.h Everywhere: Rename to_{string => deprecated_string}() where applicable 2022-12-06 08:54:33 +01:00