mirror of
https://github.com/RGBCube/serenity
synced 2025-05-30 13:58:11 +00:00
d7b6cc6421
Our existing implementation did not check the element type of the other pointer in the constructors and move assignment operators. This meant that some operations that would require explicit casting on raw pointers were done implicitly, such as: - downcasting a base class to a derived class (e.g. `Kernel::Inode` => `Kernel::ProcFSDirectoryInode` in Kernel/ProcFS.cpp), - casting to an unrelated type (e.g. `Promise<bool>` => `Promise<Empty>` in LibIMAP/Client.cpp) This, of course, allows gross violations of the type system, and makes the need to type-check less obvious before downcasting. Luckily, while adding the `static_ptr_cast`s, only two truly incorrect usages were found; in the other instances, our casts just needed to be made explicit. |
||
|---|---|---|
| .. | ||
| Client.cpp | ||
| Client.h | ||
| CMakeLists.txt | ||
| Objects.cpp | ||
| Objects.h | ||
| Parser.cpp | ||
| Parser.h | ||
| QuotedPrintable.cpp | ||
| QuotedPrintable.h | ||