mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 04:32:44 +00:00 
			
		
		
		
	 ec2b4c271f
			
		
	
	
		ec2b4c271f
		
	
	
	
	
		
			
			We would previously not return a RadioNodeList in the curious case where a named item resolves to two different elements within the form. This was not a problem when calling namedItem directly in the IDL as named_item_or_radio_node_list shadows named_item but is exposed when calling the property through array bracket notation (as an example). Fix this, and add a bunch more tests to cover HTMLFormControlsCollection.
		
			
				
	
	
		
			34 lines
		
	
	
	
		
			1,002 B
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			34 lines
		
	
	
	
		
			1,002 B
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2023, Shannon Booth <shannon@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <LibWeb/DOM/HTMLCollection.h>
 | |
| #include <LibWeb/DOM/RadioNodeList.h>
 | |
| 
 | |
| namespace Web::DOM {
 | |
| 
 | |
| class HTMLFormControlsCollection : public HTMLCollection {
 | |
|     WEB_PLATFORM_OBJECT(HTMLFormControlsCollection, HTMLCollection);
 | |
|     JS_DECLARE_ALLOCATOR(HTMLFormControlsCollection);
 | |
| 
 | |
| public:
 | |
|     [[nodiscard]] static JS::NonnullGCPtr<HTMLFormControlsCollection> create(ParentNode& root, Scope, Function<bool(Element const&)> filter);
 | |
| 
 | |
|     virtual ~HTMLFormControlsCollection() override;
 | |
| 
 | |
|     Variant<Empty, Element*, JS::Handle<RadioNodeList>> named_item_or_radio_node_list(FlyString const& name) const;
 | |
| 
 | |
| protected:
 | |
|     virtual void initialize(JS::Realm&) override;
 | |
| 
 | |
|     virtual WebIDL::ExceptionOr<JS::Value> named_item_value(FlyString const& name) const final;
 | |
| 
 | |
| private:
 | |
|     HTMLFormControlsCollection(ParentNode& root, Scope, Function<bool(Element const&)> filter);
 | |
| };
 | |
| 
 | |
| }
 |