mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 03:42:44 +00:00 
			
		
		
		
	 41a3c19cfe
			
		
	
	
		41a3c19cfe
		
	
	
	
	
		
			
			This change fixes GC-leak caused by following mutual dependency: - SVGDecodedImageData owns JS::Handle for Page. - SVGDecodedImageData is owned by visited objects. by making everything inherited from HTML::DecodedImageData and ListOfAvailableImages to be GC-allocated. Generally, if visited object has a handle, very likely we leak everything visited from object in a handle.
		
			
				
	
	
		
			46 lines
		
	
	
	
		
			1.5 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			46 lines
		
	
	
	
		
			1.5 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2023, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <LibGfx/ImmutableBitmap.h>
 | |
| #include <LibWeb/HTML/DecodedImageData.h>
 | |
| 
 | |
| namespace Web::HTML {
 | |
| 
 | |
| class AnimatedBitmapDecodedImageData final : public DecodedImageData {
 | |
|     JS_CELL(AnimatedBitmapDecodedImageData, Cell);
 | |
|     JS_DECLARE_ALLOCATOR(AnimatedBitmapDecodedImageData);
 | |
| 
 | |
| public:
 | |
|     struct Frame {
 | |
|         RefPtr<Gfx::ImmutableBitmap> bitmap;
 | |
|         int duration { 0 };
 | |
|     };
 | |
| 
 | |
|     static ErrorOr<JS::NonnullGCPtr<AnimatedBitmapDecodedImageData>> create(JS::Realm&, Vector<Frame>&&, size_t loop_count, bool animated);
 | |
|     virtual ~AnimatedBitmapDecodedImageData() override;
 | |
| 
 | |
|     virtual RefPtr<Gfx::ImmutableBitmap> bitmap(size_t frame_index, Gfx::IntSize = {}) const override;
 | |
|     virtual int frame_duration(size_t frame_index) const override;
 | |
| 
 | |
|     virtual size_t frame_count() const override { return m_frames.size(); }
 | |
|     virtual size_t loop_count() const override { return m_loop_count; }
 | |
|     virtual bool is_animated() const override { return m_animated; }
 | |
| 
 | |
|     virtual Optional<CSSPixels> intrinsic_width() const override;
 | |
|     virtual Optional<CSSPixels> intrinsic_height() const override;
 | |
|     virtual Optional<CSSPixelFraction> intrinsic_aspect_ratio() const override;
 | |
| 
 | |
| private:
 | |
|     AnimatedBitmapDecodedImageData(Vector<Frame>&&, size_t loop_count, bool animated);
 | |
| 
 | |
|     Vector<Frame> m_frames;
 | |
|     size_t m_loop_count { 0 };
 | |
|     bool m_animated { false };
 | |
| };
 | |
| 
 | |
| }
 |