mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-27 14:02:07 +00:00 
			
		
		
		
	 655d9d1462
			
		
	
	
		655d9d1462
		
	
	
	
	
		
			
			This fixes a plethora of rounding problems on many websites. In the future, we may want to replace this with fixed-point arithmetic (bug #18566) for performance (and consistency with other engines), but in the meantime this makes the web look a bit better. :^) There's a lot more things that could be converted to doubles, which would reduce the amount of casting necessary in this patch. We can do that incrementally, however.
		
			
				
	
	
		
			149 lines
		
	
	
	
		
			4.3 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			149 lines
		
	
	
	
		
			4.3 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2018-2022, Andreas Kling <kling@serenityos.org>
 | |
|  * Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #include <LibGfx/Painter.h>
 | |
| #include <LibWeb/Painting/PaintContext.h>
 | |
| 
 | |
| namespace Web {
 | |
| 
 | |
| PaintContext::PaintContext(Gfx::Painter& painter, Palette const& palette, double device_pixels_per_css_pixel)
 | |
|     : m_painter(painter)
 | |
|     , m_palette(palette)
 | |
|     , m_device_pixels_per_css_pixel(device_pixels_per_css_pixel)
 | |
| {
 | |
| }
 | |
| 
 | |
| SVGContext& PaintContext::svg_context()
 | |
| {
 | |
|     // FIXME: This is a total hack to avoid crashing on content that has SVG elements embedded directly in HTML without an <svg> element.
 | |
|     if (!m_svg_context.has_value())
 | |
|         m_svg_context = SVGContext { {} };
 | |
|     return m_svg_context.value();
 | |
| }
 | |
| 
 | |
| void PaintContext::set_svg_context(SVGContext context)
 | |
| {
 | |
|     m_svg_context = move(context);
 | |
| }
 | |
| 
 | |
| void PaintContext::clear_svg_context()
 | |
| {
 | |
|     m_svg_context.clear();
 | |
| }
 | |
| 
 | |
| CSSPixelRect PaintContext::css_viewport_rect() const
 | |
| {
 | |
|     return {
 | |
|         m_device_viewport_rect.x().value() / m_device_pixels_per_css_pixel,
 | |
|         m_device_viewport_rect.y().value() / m_device_pixels_per_css_pixel,
 | |
|         m_device_viewport_rect.width().value() / m_device_pixels_per_css_pixel,
 | |
|         m_device_viewport_rect.height().value() / m_device_pixels_per_css_pixel
 | |
|     };
 | |
| }
 | |
| 
 | |
| DevicePixels PaintContext::rounded_device_pixels(CSSPixels css_pixels) const
 | |
| {
 | |
|     return roundf(css_pixels.value() * m_device_pixels_per_css_pixel);
 | |
| }
 | |
| 
 | |
| DevicePixels PaintContext::enclosing_device_pixels(CSSPixels css_pixels) const
 | |
| {
 | |
|     return ceilf(css_pixels.value() * m_device_pixels_per_css_pixel);
 | |
| }
 | |
| 
 | |
| DevicePixels PaintContext::floored_device_pixels(CSSPixels css_pixels) const
 | |
| {
 | |
|     return floorf(css_pixels.value() * m_device_pixels_per_css_pixel);
 | |
| }
 | |
| 
 | |
| DevicePixelPoint PaintContext::rounded_device_point(CSSPixelPoint point) const
 | |
| {
 | |
|     return {
 | |
|         roundf(point.x().value() * m_device_pixels_per_css_pixel),
 | |
|         roundf(point.y().value() * m_device_pixels_per_css_pixel)
 | |
|     };
 | |
| }
 | |
| 
 | |
| DevicePixelPoint PaintContext::floored_device_point(CSSPixelPoint point) const
 | |
| {
 | |
|     return {
 | |
|         floorf(point.x().value() * m_device_pixels_per_css_pixel),
 | |
|         floorf(point.y().value() * m_device_pixels_per_css_pixel)
 | |
|     };
 | |
| }
 | |
| 
 | |
| DevicePixelRect PaintContext::enclosing_device_rect(CSSPixelRect rect) const
 | |
| {
 | |
|     return {
 | |
|         floorf(rect.x().value() * m_device_pixels_per_css_pixel),
 | |
|         floorf(rect.y().value() * m_device_pixels_per_css_pixel),
 | |
|         ceilf(rect.width().value() * m_device_pixels_per_css_pixel),
 | |
|         ceilf(rect.height().value() * m_device_pixels_per_css_pixel)
 | |
|     };
 | |
| }
 | |
| 
 | |
| DevicePixelRect PaintContext::rounded_device_rect(CSSPixelRect rect) const
 | |
| {
 | |
|     return {
 | |
|         roundf(rect.x().value() * m_device_pixels_per_css_pixel),
 | |
|         roundf(rect.y().value() * m_device_pixels_per_css_pixel),
 | |
|         roundf(rect.width().value() * m_device_pixels_per_css_pixel),
 | |
|         roundf(rect.height().value() * m_device_pixels_per_css_pixel)
 | |
|     };
 | |
| }
 | |
| 
 | |
| DevicePixelSize PaintContext::enclosing_device_size(CSSPixelSize size) const
 | |
| {
 | |
|     return {
 | |
|         ceilf(size.width().value() * m_device_pixels_per_css_pixel),
 | |
|         ceilf(size.height().value() * m_device_pixels_per_css_pixel)
 | |
|     };
 | |
| }
 | |
| 
 | |
| DevicePixelSize PaintContext::rounded_device_size(CSSPixelSize size) const
 | |
| {
 | |
|     return {
 | |
|         roundf(size.width().value() * m_device_pixels_per_css_pixel),
 | |
|         roundf(size.height().value() * m_device_pixels_per_css_pixel)
 | |
|     };
 | |
| }
 | |
| 
 | |
| CSSPixels PaintContext::scale_to_css_pixels(DevicePixels device_pixels) const
 | |
| {
 | |
|     return device_pixels.value() / m_device_pixels_per_css_pixel;
 | |
| }
 | |
| 
 | |
| CSSPixelPoint PaintContext::scale_to_css_point(DevicePixelPoint point) const
 | |
| {
 | |
|     return {
 | |
|         scale_to_css_pixels(point.x()),
 | |
|         scale_to_css_pixels(point.y())
 | |
|     };
 | |
| }
 | |
| 
 | |
| CSSPixelSize PaintContext::scale_to_css_size(DevicePixelSize size) const
 | |
| {
 | |
|     return {
 | |
|         scale_to_css_pixels(size.width()),
 | |
|         scale_to_css_pixels(size.height())
 | |
|     };
 | |
| }
 | |
| 
 | |
| CSSPixelRect PaintContext::scale_to_css_rect(DevicePixelRect rect) const
 | |
| {
 | |
|     return {
 | |
|         scale_to_css_point(rect.location()),
 | |
|         scale_to_css_size(rect.size())
 | |
|     };
 | |
| }
 | |
| 
 | |
| bool PaintContext::would_be_fully_clipped_by_painter(DevicePixelRect rect) const
 | |
| {
 | |
|     return !painter().clip_rect().intersects(rect.to_type<int>().translated(painter().translation()));
 | |
| }
 | |
| 
 | |
| }
 |