mirror of
https://github.com/RGBCube/serenity
synced 2025-10-31 22:02:44 +00:00
073071c634
If calling the executor function throws an exception, the return value
of `vm.call()` will be an empty value, which we then passed as an
argument to the reject function, which is incorrect - what it actually
needs is the exception value. This stems from a misunderstanding of the
spec I had at the time of implementing this - in their case, the
exception value is part of the completion record returned by Call().
This error was previously masked as we would use a fallback
(`value_or(js_undefined())` for the empty value argument, but that was
removed in 57f7e6e.
Fixes #8447.
134 lines
4.5 KiB
C++
134 lines
4.5 KiB
C++
/*
|
|
* Copyright (c) 2021, Linus Groh <linusg@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibJS/Interpreter.h>
|
|
#include <LibJS/Runtime/AbstractOperations.h>
|
|
#include <LibJS/Runtime/Error.h>
|
|
#include <LibJS/Runtime/FunctionObject.h>
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
|
#include <LibJS/Runtime/Promise.h>
|
|
#include <LibJS/Runtime/PromiseConstructor.h>
|
|
#include <LibJS/Runtime/PromiseReaction.h>
|
|
|
|
namespace JS {
|
|
|
|
PromiseConstructor::PromiseConstructor(GlobalObject& global_object)
|
|
: NativeFunction(vm().names.Promise.as_string(), *global_object.function_prototype())
|
|
{
|
|
}
|
|
|
|
void PromiseConstructor::initialize(GlobalObject& global_object)
|
|
{
|
|
auto& vm = this->vm();
|
|
NativeFunction::initialize(global_object);
|
|
|
|
// 27.2.4.4 Promise.prototype, https://tc39.es/ecma262/#sec-promise.prototype
|
|
define_property(vm.names.prototype, global_object.promise_prototype(), 0);
|
|
|
|
define_property(vm.names.length, Value(1), Attribute::Configurable);
|
|
|
|
u8 attr = Attribute::Writable | Attribute::Configurable;
|
|
// TODO: Implement these functions below and uncomment this.
|
|
// define_native_function(vm.names.all, all, 1, attr);
|
|
// define_native_function(vm.names.allSettled, all_settled, 1, attr);
|
|
// define_native_function(vm.names.any, any, 1, attr);
|
|
// define_native_function(vm.names.race, race, 1, attr);
|
|
define_native_function(vm.names.reject, reject, 1, attr);
|
|
define_native_function(vm.names.resolve, resolve, 1, attr);
|
|
|
|
define_native_accessor(*vm.well_known_symbol_species(), symbol_species_getter, {}, Attribute::Configurable);
|
|
}
|
|
|
|
// 27.2.3.1 Promise ( executor ), https://tc39.es/ecma262/#sec-promise-executor
|
|
Value PromiseConstructor::call()
|
|
{
|
|
auto& vm = this->vm();
|
|
vm.throw_exception<TypeError>(global_object(), ErrorType::ConstructorWithoutNew, vm.names.Promise);
|
|
return {};
|
|
}
|
|
|
|
// 27.2.3.1 Promise ( executor ), https://tc39.es/ecma262/#sec-promise-executor
|
|
Value PromiseConstructor::construct(FunctionObject& new_target)
|
|
{
|
|
auto& vm = this->vm();
|
|
auto& global_object = this->global_object();
|
|
|
|
auto executor = vm.argument(0);
|
|
if (!executor.is_function()) {
|
|
vm.throw_exception<TypeError>(global_object, ErrorType::PromiseExecutorNotAFunction);
|
|
return {};
|
|
}
|
|
|
|
auto* promise = ordinary_create_from_constructor<Promise>(global_object, new_target, &GlobalObject::promise_prototype);
|
|
if (vm.exception())
|
|
return {};
|
|
|
|
auto [resolve_function, reject_function] = promise->create_resolving_functions();
|
|
|
|
(void)vm.call(executor.as_function(), js_undefined(), &resolve_function, &reject_function);
|
|
if (auto* exception = vm.exception()) {
|
|
vm.clear_exception();
|
|
vm.stop_unwind();
|
|
(void)vm.call(reject_function, js_undefined(), exception->value());
|
|
}
|
|
return promise;
|
|
}
|
|
|
|
// 27.2.4.1 Promise.all ( iterable ), https://tc39.es/ecma262/#sec-promise.all
|
|
JS_DEFINE_NATIVE_FUNCTION(PromiseConstructor::all)
|
|
{
|
|
TODO();
|
|
}
|
|
|
|
// 27.2.4.2 Promise.allSettled ( iterable ), https://tc39.es/ecma262/#sec-promise.allsettled
|
|
JS_DEFINE_NATIVE_FUNCTION(PromiseConstructor::all_settled)
|
|
{
|
|
TODO();
|
|
}
|
|
|
|
// 27.2.4.3 Promise.any ( iterable ), https://tc39.es/ecma262/#sec-promise.any
|
|
JS_DEFINE_NATIVE_FUNCTION(PromiseConstructor::any)
|
|
{
|
|
TODO();
|
|
}
|
|
|
|
// 27.2.4.5 Promise.race ( iterable ), https://tc39.es/ecma262/#sec-promise.race
|
|
JS_DEFINE_NATIVE_FUNCTION(PromiseConstructor::race)
|
|
{
|
|
TODO();
|
|
}
|
|
|
|
// 27.2.4.6 Promise.reject ( r ), https://tc39.es/ecma262/#sec-promise.reject
|
|
JS_DEFINE_NATIVE_FUNCTION(PromiseConstructor::reject)
|
|
{
|
|
auto* constructor = vm.this_value(global_object).to_object(global_object);
|
|
if (!constructor)
|
|
return {};
|
|
auto promise_capability = new_promise_capability(global_object, constructor);
|
|
if (vm.exception())
|
|
return {};
|
|
auto reason = vm.argument(0);
|
|
[[maybe_unused]] auto result = vm.call(*promise_capability.reject, js_undefined(), reason);
|
|
return promise_capability.promise;
|
|
}
|
|
|
|
// 27.2.4.7 Promise.resolve ( x ), https://tc39.es/ecma262/#sec-promise.resolve
|
|
JS_DEFINE_NATIVE_FUNCTION(PromiseConstructor::resolve)
|
|
{
|
|
auto* constructor = vm.this_value(global_object).to_object(global_object);
|
|
if (!constructor)
|
|
return {};
|
|
auto value = vm.argument(0);
|
|
return promise_resolve(global_object, *constructor, value);
|
|
}
|
|
|
|
// 27.2.4.8 get Promise [ @@species ], https://tc39.es/ecma262/#sec-get-promise-@@species
|
|
JS_DEFINE_NATIVE_GETTER(PromiseConstructor::symbol_species_getter)
|
|
{
|
|
return vm.this_value(global_object);
|
|
}
|
|
|
|
}
|