mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 21:52:45 +00:00 
			
		
		
		
	 d1c109be96
			
		
	
	
		d1c109be96
		
	
	
	
	
		
			
			Namely the Proxy revocation, Promise resolving, Promise then/catch finally, and Promise GetCapabilitiesExecutor functions. They were all missing an explicit 'Attribute::Configurable' argument and therefore incorrectly used the default attributes (writable, enumerable, configurable).
		
			
				
	
	
		
			45 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			45 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2021, Linus Groh <linusg@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #include <LibJS/Runtime/GlobalObject.h>
 | |
| #include <LibJS/Runtime/NativeFunction.h>
 | |
| #include <LibJS/Runtime/Promise.h>
 | |
| #include <LibJS/Runtime/PromiseResolvingFunction.h>
 | |
| 
 | |
| namespace JS {
 | |
| 
 | |
| PromiseResolvingFunction* PromiseResolvingFunction::create(GlobalObject& global_object, Promise& promise, AlreadyResolved& already_resolved, FunctionType function)
 | |
| {
 | |
|     return global_object.heap().allocate<PromiseResolvingFunction>(global_object, promise, already_resolved, move(function), *global_object.function_prototype());
 | |
| }
 | |
| 
 | |
| PromiseResolvingFunction::PromiseResolvingFunction(Promise& promise, AlreadyResolved& already_resolved, FunctionType native_function, Object& prototype)
 | |
|     : NativeFunction(prototype)
 | |
|     , m_promise(promise)
 | |
|     , m_already_resolved(already_resolved)
 | |
|     , m_native_function(move(native_function))
 | |
| {
 | |
| }
 | |
| 
 | |
| void PromiseResolvingFunction::initialize(GlobalObject& global_object)
 | |
| {
 | |
|     Base::initialize(global_object);
 | |
|     define_property(vm().names.length, Value(1), Attribute::Configurable);
 | |
| }
 | |
| 
 | |
| Value PromiseResolvingFunction::call()
 | |
| {
 | |
|     return m_native_function(vm(), global_object(), m_promise, m_already_resolved);
 | |
| }
 | |
| 
 | |
| void PromiseResolvingFunction::visit_edges(Cell::Visitor& visitor)
 | |
| {
 | |
|     Base::visit_edges(visitor);
 | |
|     visitor.visit(&m_promise);
 | |
|     visitor.visit(&m_already_resolved);
 | |
| }
 | |
| 
 | |
| }
 |