mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 07:32:44 +00:00 
			
		
		
		
	 e64a8751d1
			
		
	
	
		e64a8751d1
		
	
	
	
	
		
			
			The dollar sign is a special character in POSIX shells and in the Ninja build file format. If the file name contains a `$`, something goes wrong in the escaping/unescaping of this symbol, and CMake/GCC/Clang generate invalid dependency files where not all instances of `$` are escaped properly. Because of this, Ninja fails to rebuild `$262Object.cpp` if the headers included by it have changed. Stale `$262Object.cpp.o` files have been the cause of mysterious crashes multiple times which only go away after doing a clean build. Let's prevent these from happening again by removing the `$` from the filename.
		
			
				
	
	
		
			44 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			44 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2021-2022, Linus Groh <linusg@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #include <AK/Format.h>
 | |
| #include <LibJS/Contrib/Test262/262Object.h>
 | |
| #include <LibJS/Contrib/Test262/AgentObject.h>
 | |
| #include <LibJS/Contrib/Test262/GlobalObject.h>
 | |
| #include <LibJS/Heap/Cell.h>
 | |
| #include <LibJS/Runtime/GlobalObject.h>
 | |
| #include <LibJS/Runtime/VM.h>
 | |
| 
 | |
| namespace JS::Test262 {
 | |
| 
 | |
| ThrowCompletionOr<void> GlobalObject::initialize(Realm& realm)
 | |
| {
 | |
|     MUST_OR_THROW_OOM(Base::initialize(realm));
 | |
| 
 | |
|     m_$262 = MUST_OR_THROW_OOM(vm().heap().allocate<$262Object>(realm, realm));
 | |
| 
 | |
|     // https://github.com/tc39/test262/blob/master/INTERPRETING.md#host-defined-functions
 | |
|     u8 attr = Attribute::Writable | Attribute::Configurable;
 | |
|     define_native_function(realm, "print", print, 1, attr);
 | |
|     define_direct_property("$262", m_$262, attr);
 | |
| 
 | |
|     return {};
 | |
| }
 | |
| 
 | |
| void GlobalObject::visit_edges(Cell::Visitor& visitor)
 | |
| {
 | |
|     Base::visit_edges(visitor);
 | |
|     visitor.visit(m_$262);
 | |
| }
 | |
| 
 | |
| JS_DEFINE_NATIVE_FUNCTION(GlobalObject::print)
 | |
| {
 | |
|     auto string = TRY(vm.argument(0).to_deprecated_string(vm));
 | |
|     outln("{}", string);
 | |
|     return js_undefined();
 | |
| }
 | |
| 
 | |
| }
 |