mirror of
https://github.com/RGBCube/serenity
synced 2025-10-31 22:22:45 +00:00
7c1f645e27
There is a big mix of LockRefPtrs all over the Networking subsystem, as well as lots of room for improvements with our locking patterns, which this commit will not pursue, but will give a good start for such work. To deal with this situation, we change the following things: - Creating instances of NetworkAdapter should always yield a non-locking NonnullRefPtr. Acquiring an instance from the NetworkingManagement should give a simple RefPtr,as giving LockRefPtr does not really protect from concurrency problems in such case. - Since NetworkingManagement works with normal RefPtrs we should protect all instances of RefPtr<NetworkAdapter> with SpinlockProtected to ensure references are gone unexpectedly. - Protect the so_error class member with a proper spinlock. This happens to be important because the clear_so_error() method lacked any proper locking measures. It also helps preventing a possible TOCTOU when we might do a more fine-grained locking in the Socket code, so this could be definitely a start for this. - Change unnecessary LockRefPtr<PacketWithTimestamp> in the structure of OutgoingPacket to a simple RefPtr<PacketWithTimestamp> as the whole list should be MutexProtected.
72 lines
2.2 KiB
C++
72 lines
2.2 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/IPv4Address.h>
|
|
#include <AK/RefPtr.h>
|
|
#include <Kernel/Locking/MutexProtected.h>
|
|
#include <Kernel/Net/NetworkAdapter.h>
|
|
#include <Kernel/Thread.h>
|
|
|
|
namespace Kernel {
|
|
|
|
struct Route final : public AtomicRefCounted<Route> {
|
|
Route(IPv4Address const& destination, IPv4Address const& gateway, IPv4Address const& netmask, u16 flags, NonnullRefPtr<NetworkAdapter> adapter)
|
|
: destination(destination)
|
|
, gateway(gateway)
|
|
, netmask(netmask)
|
|
, flags(flags)
|
|
, adapter(adapter)
|
|
{
|
|
}
|
|
|
|
bool operator==(Route const& other) const
|
|
{
|
|
return destination == other.destination && netmask == other.netmask && flags == other.flags && adapter.ptr() == other.adapter.ptr();
|
|
}
|
|
|
|
bool matches(Route const& other) const
|
|
{
|
|
return destination == other.destination && (gateway == other.gateway || other.gateway.is_zero()) && netmask == other.netmask && flags == other.flags && adapter.ptr() == other.adapter.ptr();
|
|
}
|
|
|
|
const IPv4Address destination;
|
|
const IPv4Address gateway;
|
|
const IPv4Address netmask;
|
|
const u16 flags;
|
|
NonnullRefPtr<NetworkAdapter> const adapter;
|
|
|
|
IntrusiveListNode<Route, RefPtr<Route>> route_list_node {};
|
|
using RouteList = IntrusiveList<&Route::route_list_node>;
|
|
};
|
|
|
|
struct RoutingDecision {
|
|
RefPtr<NetworkAdapter> adapter;
|
|
MACAddress next_hop;
|
|
|
|
bool is_zero() const;
|
|
};
|
|
|
|
enum class UpdateTable {
|
|
Set,
|
|
Delete,
|
|
};
|
|
|
|
void update_arp_table(IPv4Address const&, MACAddress const&, UpdateTable update);
|
|
ErrorOr<void> update_routing_table(IPv4Address const& destination, IPv4Address const& gateway, IPv4Address const& netmask, u16 flags, RefPtr<NetworkAdapter> const adapter, UpdateTable update);
|
|
|
|
enum class AllowUsingGateway {
|
|
Yes,
|
|
No,
|
|
};
|
|
|
|
RoutingDecision route_to(IPv4Address const& target, IPv4Address const& source, RefPtr<NetworkAdapter> const through = nullptr, AllowUsingGateway = AllowUsingGateway::Yes);
|
|
|
|
SpinlockProtected<HashMap<IPv4Address, MACAddress>, LockRank::None>& arp_table();
|
|
SpinlockProtected<Route::RouteList, LockRank::None>& routing_table();
|
|
|
|
}
|