1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2026-01-19 20:30:59 +00:00
serenity/Tests/LibWeb/Text
Aliaksandr Kalenik 8a829be25c LibWeb: Handle scenario when Window property setter is called on global
This commit fixes a regression introduced in
1528e9109c.

Turns out that the type of `this_value` in the property setter of the
Window object depends on how the variable is accessed. If the property
is accessed as a global variable, then this_value is of type `Window`.
For example:
```js
performance = null
```

However, when it is accessed as a property of the window object,
`this_value` is of type `WindowProxy`. For example:
```js
window.performance = null
```

This commit updates the window property setters generator to handle
both scenarios.

With this change https://discord.com/login works again.
2024-02-25 12:55:30 +01:00
..
data Tests/LibWeb: Move LibWeb test frames to their own directory 2024-02-19 22:11:59 -05:00
expected LibWeb: Handle scenario when Window property setter is called on global 2024-02-25 12:55:30 +01:00
input LibWeb: Handle scenario when Window property setter is called on global 2024-02-25 12:55:30 +01:00