mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 22:02:44 +00:00 
			
		
		
		
	 6e70670e0b
			
		
	
	
		6e70670e0b
		
	
	
	
	
		
			
			Previously, we were running the "load fonts if needed" machine at the start of every style computation. That was a lot of unnecessary work, especially on sites with lots of style rules, since we had to traverse every style sheet to see if any @font-face rules needed loading. With this patch, we now load fonts once per sheet, right after adding it to a document's style sheet list.
		
			
				
	
	
		
			48 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			48 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | ||
|  * Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
 | ||
|  *
 | ||
|  * SPDX-License-Identifier: BSD-2-Clause
 | ||
|  */
 | ||
| 
 | ||
| #include <LibWeb/CSS/StyleSheetList.h>
 | ||
| #include <LibWeb/DOM/Document.h>
 | ||
| 
 | ||
| namespace Web::CSS {
 | ||
| 
 | ||
| void StyleSheetList::add_sheet(NonnullRefPtr<CSSStyleSheet> sheet)
 | ||
| {
 | ||
|     VERIFY(!m_sheets.contains_slow(sheet));
 | ||
|     sheet->set_style_sheet_list({}, this);
 | ||
|     m_sheets.append(sheet);
 | ||
| 
 | ||
|     m_document.style_computer().invalidate_rule_cache();
 | ||
|     m_document.style_computer().load_fonts_from_sheet(*sheet);
 | ||
|     m_document.invalidate_style();
 | ||
| }
 | ||
| 
 | ||
| void StyleSheetList::remove_sheet(CSSStyleSheet& sheet)
 | ||
| {
 | ||
|     sheet.set_style_sheet_list({}, nullptr);
 | ||
|     m_sheets.remove_first_matching([&](auto& entry) { return &*entry == &sheet; });
 | ||
| 
 | ||
|     m_document.style_computer().invalidate_rule_cache();
 | ||
|     m_document.invalidate_style();
 | ||
| }
 | ||
| 
 | ||
| StyleSheetList::StyleSheetList(DOM::Document& document)
 | ||
|     : m_document(document)
 | ||
| {
 | ||
| }
 | ||
| 
 | ||
| // https://www.w3.org/TR/cssom/#ref-for-dfn-supported-property-indices%E2%91%A1
 | ||
| bool StyleSheetList::is_supported_property_index(u32 index) const
 | ||
| {
 | ||
|     // The object’s supported property indices are the numbers in the range zero to one less than the number of CSS style sheets represented by the collection.
 | ||
|     // If there are no such CSS style sheets, then there are no supported property indices.
 | ||
|     if (m_sheets.is_empty())
 | ||
|         return false;
 | ||
| 
 | ||
|     return index < m_sheets.size();
 | ||
| }
 | ||
| 
 | ||
| }
 |