mirror of
https://github.com/RGBCube/serenity
synced 2025-05-14 08:34:57 +00:00

The dynamic linker is already taking care of this for us. Now that crt0 is statically linked into each executable and shared library this breaks things because initializers are invoked twice. Before this PR this didn't crash because crt0 and its _start() function was contained in LibC and thus only LibC's initializers were invoked several times which wasn't as much of a problem because these initializers didn't have any side effects (such as malloc/free). However, user programs are more likely to have constructors with side effects, e.g.: std::string g_test("hello!"); This would allocate memory when the constructor is invoked. When it is invoked again the original allocation would be leaked and another copy of the string would get allocated. Worse still, when the destructors are invoked twice the memory would get free'd twice which would likely crash the program.
67 lines
2.3 KiB
C++
67 lines
2.3 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
|
|
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <AK/Types.h>
|
|
#include <assert.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <sys/internals.h>
|
|
#include <unistd.h>
|
|
|
|
extern "C" {
|
|
|
|
extern u32 __stack_chk_guard;
|
|
|
|
int main(int, char**, char**);
|
|
|
|
// Tell the compiler that this may be called from somewhere else.
|
|
int _start(int argc, char** argv, char** env);
|
|
|
|
int _start(int argc, char** argv, char** env)
|
|
{
|
|
u32 original_stack_chk = __stack_chk_guard;
|
|
arc4random_buf(&__stack_chk_guard, sizeof(__stack_chk_guard));
|
|
|
|
if (__stack_chk_guard == 0)
|
|
__stack_chk_guard = original_stack_chk;
|
|
|
|
environ = env;
|
|
__environ_is_malloced = false;
|
|
|
|
_init();
|
|
|
|
int status = main(argc, argv, environ);
|
|
|
|
exit(status);
|
|
|
|
// We should never get here, but if we ever do, make sure to
|
|
// restore the stack guard to the value we entered _start with.
|
|
// Then we won't trigger the stack canary check on the way out.
|
|
__stack_chk_guard = original_stack_chk;
|
|
|
|
return 20150614;
|
|
}
|
|
}
|