mirror of
https://github.com/RGBCube/serenity
synced 2025-10-31 15:32:46 +00:00
971d6ce16f
glCullFace only accepts GL_FRONT, GL_BACK and GL_FRONT_AND_BACK. We checked if the mode was valid by performing ``` cull_mode < GL_FRONT || cull_mode > GL_FRONT_AND_BACK ``` However, this range also contains GL_LEFT and GL_RIGHT, which we would accept when we should return a GL_INVALID_ENUM error.
55 lines
2 KiB
C++
55 lines
2 KiB
C++
/*
|
|
* Copyright (c) 2022, Luke Wilde <lukew@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibGL/GL/gl.h>
|
|
#include <LibGL/GLContext.h>
|
|
#include <LibTest/TestCase.h>
|
|
|
|
static NonnullOwnPtr<GL::GLContext> create_testing_context()
|
|
{
|
|
auto bitmap = MUST(Gfx::Bitmap::try_create(Gfx::BitmapFormat::BGRx8888, { 1, 1 }));
|
|
auto context = GL::create_context(*bitmap);
|
|
GL::make_context_current(context);
|
|
return context;
|
|
}
|
|
|
|
TEST_CASE(0001_gl_gen_textures_does_not_return_the_same_texture_name_twice_unless_deleted)
|
|
{
|
|
// https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glGenTextures.xhtml
|
|
// "Texture names returned by a call to glGenTextures are not returned by subsequent calls, unless they are first deleted with glDeleteTextures."
|
|
auto context = create_testing_context();
|
|
|
|
GLuint texture1 = 0;
|
|
GLuint texture2 = 0;
|
|
|
|
glGenTextures(1, &texture1);
|
|
|
|
// glDeleteTextures previously did not check that the texture name was allocated by glGenTextures before adding it to the free texture name list.
|
|
// This means that if you delete a texture twice in a row, the name will appear twice in the free texture list, making glGenTextures return the
|
|
// same texture name twice in a row.
|
|
glDeleteTextures(1, &texture1);
|
|
glDeleteTextures(1, &texture1);
|
|
|
|
texture1 = 0;
|
|
|
|
glGenTextures(1, &texture1);
|
|
glGenTextures(1, &texture2);
|
|
|
|
EXPECT_NE(texture1, texture2);
|
|
}
|
|
|
|
TEST_CASE(0002_gl_cull_face_does_not_accept_left_and_right)
|
|
{
|
|
auto context = create_testing_context();
|
|
|
|
// glCullFace only accepts GL_FRONT, GL_BACK and GL_FRONT_AND_BACK. We checked if the mode was valid by performing cull_mode < GL_FRONT || cull_mode > GL_FRONT_AND_BACK.
|
|
// However, this range also contains GL_LEFT and GL_RIGHT, which we would accept when we should return a GL_INVALID_ENUM error.
|
|
glCullFace(GL_LEFT);
|
|
EXPECT_EQ(glGetError(), static_cast<GLenum>(GL_INVALID_ENUM));
|
|
|
|
glCullFace(GL_RIGHT);
|
|
EXPECT_EQ(glGetError(), static_cast<GLenum>(GL_INVALID_ENUM));
|
|
}
|