mirror of
https://github.com/RGBCube/serenity
synced 2025-05-31 18:38:10 +00:00
9f24c1b34c
When embedding an SVG in an img element, if the external SVG's root element has both width and height attributes, but no viewBox attribute, we now create a fallback viewBox with "0 0 width height". This appears to match the behavior of other browsers. Inspired by discussion on Mozilla's bug tracker: https://bugzilla.mozilla.org/show_bug.cgi?id=614649
56 lines
1.6 KiB
C++
56 lines
1.6 KiB
C++
/*
|
|
* Copyright (c) 2020, Matthew Olsson <matthewcolsson@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibGfx/Bitmap.h>
|
|
#include <LibWeb/SVG/AttributeParser.h>
|
|
#include <LibWeb/SVG/SVGGraphicsElement.h>
|
|
#include <LibWeb/SVG/ViewBox.h>
|
|
|
|
namespace Web::SVG {
|
|
|
|
class SVGSVGElement final : public SVGGraphicsElement {
|
|
WEB_PLATFORM_OBJECT(SVGSVGElement, SVGGraphicsElement);
|
|
|
|
public:
|
|
virtual JS::GCPtr<Layout::Node> create_layout_node(NonnullRefPtr<CSS::StyleProperties>) override;
|
|
|
|
virtual void apply_presentational_hints(CSS::StyleProperties&) const override;
|
|
|
|
virtual bool requires_svg_container() const override { return false; }
|
|
virtual bool is_svg_container() const override { return true; }
|
|
|
|
[[nodiscard]] Optional<ViewBox> view_box() const;
|
|
Optional<PreserveAspectRatio> const& preserve_aspect_ratio() const { return m_preserve_aspect_ratio; }
|
|
|
|
void set_fallback_view_box_for_svg_as_image(Optional<ViewBox>);
|
|
|
|
private:
|
|
SVGSVGElement(DOM::Document&, DOM::QualifiedName);
|
|
|
|
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
|
|
|
|
virtual bool is_svg_svg_element() const override { return true; }
|
|
|
|
virtual void parse_attribute(DeprecatedFlyString const& name, DeprecatedString const& value) override;
|
|
|
|
void update_fallback_view_box_for_svg_as_image();
|
|
|
|
Optional<ViewBox> m_view_box;
|
|
Optional<PreserveAspectRatio> m_preserve_aspect_ratio;
|
|
|
|
Optional<ViewBox> m_fallback_view_box_for_svg_as_image;
|
|
};
|
|
|
|
}
|
|
|
|
namespace Web::DOM {
|
|
|
|
template<>
|
|
inline bool Node::fast_is<SVG::SVGSVGElement>() const { return is_svg_svg_element(); }
|
|
|
|
}
|