mirror of
https://github.com/RGBCube/serenity
synced 2025-05-14 06:54:58 +00:00
a10e63f08e
SysFS, ProcFS and DevPtsFS were all sending filetype 0 when traversing their directories, but it is actually very easy to send proper filetypes in these filesystems. This patch binds all RAM backed filesystems to use only one enum for their internal filetype, to simplify the implementation and allow sharing of code. Please note that the Plan9FS case is currently not solved as I am not familiar with this filesystem and its constructs. The ProcFS mostly keeps track of the filetype, and a fix was needed for the /proc root directory - all processes exhibit a directory inside it which makes it very easy to hardcode the directory filetype for them. There's also the `self` symlink inode which is now exposed as DT_LNK. As for SysFS, we could leverage the fact everything inherits from the SysFSComponent class, so we could have a virtual const method to return the proper filetype. Most of the files in SysFS are "regular" files though, so the base class has a non-pure virtual method. Lastly, the DevPtsFS simply hardcodes '.' and '..' as directory file type, and everything else is hardcoded to send the character device file type, as this filesystem is only exposing character pts device files.
125 lines
3.2 KiB
C++
125 lines
3.2 KiB
C++
/*
|
|
* Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
|
|
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <Kernel/Devices/DeviceManagement.h>
|
|
#include <Kernel/FileSystem/DevPtsFS/Inode.h>
|
|
#include <Kernel/FileSystem/RAMBackedFileType.h>
|
|
|
|
namespace Kernel {
|
|
|
|
static InodeIndex pty_index_to_inode_index(unsigned pty_index)
|
|
{
|
|
return pty_index + 2;
|
|
}
|
|
|
|
DevPtsFSInode::DevPtsFSInode(DevPtsFS& fs, InodeIndex index, SlavePTY* pty)
|
|
: Inode(fs, index)
|
|
{
|
|
if (pty)
|
|
m_pty = *pty;
|
|
}
|
|
|
|
DevPtsFSInode::~DevPtsFSInode() = default;
|
|
|
|
ErrorOr<size_t> DevPtsFSInode::read_bytes_locked(off_t, size_t, UserOrKernelBuffer&, OpenFileDescription*) const
|
|
{
|
|
VERIFY_NOT_REACHED();
|
|
}
|
|
|
|
ErrorOr<size_t> DevPtsFSInode::write_bytes_locked(off_t, size_t, UserOrKernelBuffer const&, OpenFileDescription*)
|
|
{
|
|
VERIFY_NOT_REACHED();
|
|
}
|
|
|
|
InodeMetadata DevPtsFSInode::metadata() const
|
|
{
|
|
if (auto pty = m_pty.strong_ref()) {
|
|
auto metadata = m_metadata;
|
|
metadata.mtime = pty->time_of_last_write();
|
|
return metadata;
|
|
}
|
|
return m_metadata;
|
|
}
|
|
|
|
ErrorOr<void> DevPtsFSInode::traverse_as_directory(Function<ErrorOr<void>(FileSystem::DirectoryEntryView const&)> callback) const
|
|
{
|
|
if (identifier().index() > 1)
|
|
return ENOTDIR;
|
|
|
|
TRY(callback({ "."sv, identifier(), to_underlying(RAMBackedFileType::Directory) }));
|
|
TRY(callback({ ".."sv, identifier(), to_underlying(RAMBackedFileType::Directory) }));
|
|
|
|
return SlavePTY::all_instances().with([&](auto& list) -> ErrorOr<void> {
|
|
StringBuilder builder;
|
|
for (SlavePTY& slave_pty : list) {
|
|
builder.clear();
|
|
TRY(builder.try_appendff("{}", slave_pty.index()));
|
|
// NOTE: We represent directory entries with DT_CHR as all
|
|
// inodes in this filesystem are assumed to be char devices.
|
|
TRY(callback({ builder.string_view(), { fsid(), pty_index_to_inode_index(slave_pty.index()) }, to_underlying(RAMBackedFileType::Character) }));
|
|
}
|
|
return {};
|
|
});
|
|
}
|
|
|
|
ErrorOr<NonnullRefPtr<Inode>> DevPtsFSInode::lookup(StringView name)
|
|
{
|
|
VERIFY(identifier().index() == 1);
|
|
|
|
if (name == "." || name == "..")
|
|
return *this;
|
|
|
|
auto pty_index = name.to_number<unsigned>();
|
|
if (!pty_index.has_value())
|
|
return ENOENT;
|
|
|
|
return SlavePTY::all_instances().with([&](auto& list) -> ErrorOr<NonnullRefPtr<Inode>> {
|
|
for (SlavePTY& slave_pty : list) {
|
|
if (slave_pty.index() != pty_index.value())
|
|
continue;
|
|
return fs().get_inode({ fsid(), pty_index_to_inode_index(pty_index.value()) });
|
|
}
|
|
return ENOENT;
|
|
});
|
|
}
|
|
|
|
ErrorOr<void> DevPtsFSInode::flush_metadata()
|
|
{
|
|
return {};
|
|
}
|
|
|
|
ErrorOr<void> DevPtsFSInode::add_child(Inode&, StringView, mode_t)
|
|
{
|
|
return EROFS;
|
|
}
|
|
|
|
ErrorOr<NonnullRefPtr<Inode>> DevPtsFSInode::create_child(StringView, mode_t, dev_t, UserID, GroupID)
|
|
{
|
|
return EROFS;
|
|
}
|
|
|
|
ErrorOr<void> DevPtsFSInode::remove_child(StringView)
|
|
{
|
|
return EROFS;
|
|
}
|
|
|
|
ErrorOr<void> DevPtsFSInode::replace_child(StringView, Inode&)
|
|
{
|
|
return EROFS;
|
|
}
|
|
|
|
ErrorOr<void> DevPtsFSInode::chmod(mode_t)
|
|
{
|
|
return EROFS;
|
|
}
|
|
|
|
ErrorOr<void> DevPtsFSInode::chown(UserID, GroupID)
|
|
{
|
|
return EROFS;
|
|
}
|
|
|
|
}
|