RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2026-01-13 00:21:01 +00:00
Code Issues Activity Actions
serenity/Applications
History
Andreas Kling b29ff7b821 LibGUI: Don't use Core::Object::add() to instantiate dialogs 
Now that add() returns a WidgetType&, we can't rely on the parent of a
GUI::Dialog to still keep it alive after exec() returns. This happens
because exec() will call remove_from_parent() on itself before
returning.

And so we go back to the old idiom for creating a GUI::Dialog centered
above a specific window. Just call GUI::Dialog::construct(), passing
the "parent" window as the last parameter.
2020-03-04 21:04:06 +01:00
..
About LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
Browser LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
Calculator LibGUI: Some more convenience functions for constructing widgets 2020-03-03 22:37:48 +01:00
ChanViewer LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
DisplayProperties LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
FileManager LibGUI: Don't use Core::Object::add() to instantiate dialogs 2020-03-04 21:04:06 +01:00
FontEditor LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
Help LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
HexEditor LibGUI: Don't use Core::Object::add() to instantiate dialogs 2020-03-04 21:04:06 +01:00
IRCClient LibGUI: Don't use Core::Object::add() to instantiate dialogs 2020-03-04 21:04:06 +01:00
PaintBrush LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
Piano LibGUI: Use GUI::Window::set_main_widget<WidgetType>() in clients 2020-03-04 14:26:16 +01:00
QuickShow LibGUI: Use GUI::Window::set_main_widget<WidgetType>() in clients 2020-03-04 14:26:16 +01:00
SoundPlayer LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
SystemMenu LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
SystemMonitor LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
Taskbar LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
Terminal LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
TextEditor LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
Welcome LibCore: Make Core::Object::add<ChildType> return a ChildType& 2020-03-04 21:04:06 +01:00
Makefile Build: Only look at SUBDIRS with Makefiles 2020-02-25 19:56:48 +01:00