mirror of
https://github.com/RGBCube/serenity
synced 2025-06-19 18:02:08 +00:00
aee4786d8e
This singleton simplifies many aspects that we struggled with before: 1. There's no need to make derived classes of Device expose the constructor as public anymore. The singleton is a friend of them, so he can call the constructor. This solves the issue with try_create_device helper neatly, hopefully for good. 2. Getting a reference of the NullDevice is now being done from this singleton, which means that NullDevice no longer needs to use its own singleton, and we can apply the try_create_device helper on it too :) 3. We can now defer registration completely after the Device constructor which means the Device constructor is merely assigning the major and minor numbers of the Device, and the try_create_device helper ensures it calls the after_inserting method immediately after construction. This creates a great opportunity to make registration more OOM-safe.
58 lines
1.7 KiB
C++
58 lines
1.7 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <AK/StringView.h>
|
|
#include <Kernel/Devices/DeviceManagement.h>
|
|
#include <Kernel/FileSystem/OpenFileDescription.h>
|
|
#include <Kernel/Sections.h>
|
|
#include <Kernel/Storage/IDEChannel.h>
|
|
#include <Kernel/Storage/IDEController.h>
|
|
#include <Kernel/Storage/PATADiskDevice.h>
|
|
|
|
namespace Kernel {
|
|
|
|
UNMAP_AFTER_INIT NonnullRefPtr<PATADiskDevice> PATADiskDevice::create(const IDEController& controller, IDEChannel& channel, DriveType type, InterfaceType interface_type, u16 capabilities, u64 max_addressable_block)
|
|
{
|
|
auto device_or_error = DeviceManagement::try_create_device<PATADiskDevice>(controller, channel, type, interface_type, capabilities, max_addressable_block);
|
|
// FIXME: Find a way to propagate errors
|
|
VERIFY(!device_or_error.is_error());
|
|
return device_or_error.release_value();
|
|
}
|
|
|
|
UNMAP_AFTER_INIT PATADiskDevice::PATADiskDevice(const IDEController& controller, IDEChannel& channel, DriveType type, InterfaceType interface_type, u16 capabilities, u64 max_addressable_block)
|
|
: StorageDevice(controller, 512, max_addressable_block)
|
|
, m_capabilities(capabilities)
|
|
, m_channel(channel)
|
|
, m_drive_type(type)
|
|
, m_interface_type(interface_type)
|
|
{
|
|
}
|
|
|
|
UNMAP_AFTER_INIT PATADiskDevice::~PATADiskDevice()
|
|
{
|
|
}
|
|
|
|
StringView PATADiskDevice::class_name() const
|
|
{
|
|
return "PATADiskDevice";
|
|
}
|
|
|
|
void PATADiskDevice::start_request(AsyncBlockDeviceRequest& request)
|
|
{
|
|
m_channel->start_request(request, is_slave(), m_capabilities);
|
|
}
|
|
|
|
String PATADiskDevice::storage_name() const
|
|
{
|
|
return String::formatted("hd{:c}", 'a' + minor());
|
|
}
|
|
|
|
bool PATADiskDevice::is_slave() const
|
|
{
|
|
return m_drive_type == DriveType::Slave;
|
|
}
|
|
|
|
}
|