mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 12:02:43 +00:00 
			
		
		
		
	 f5de4f24b2
			
		
	
	
		f5de4f24b2
		
	
	
	
	
		
			
			Instead of doing so in the constructor, let's do immediately after the constructor, so we can safely pass a reference of a Device, so the SysFSDeviceComponent constructor can use that object to identify whether it's a block device or a character device. This allows to us to not hold a device in SysFSDeviceComponent with a RefPtr. Also, we also call the before_removing method in both SlavePTY::unref and File::unref, so because Device has that method being overrided, it can ensure the device is removed always cleanly.
		
			
				
	
	
		
			57 lines
		
	
	
	
		
			1.7 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			57 lines
		
	
	
	
		
			1.7 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #include <AK/StringView.h>
 | |
| #include <Kernel/FileSystem/OpenFileDescription.h>
 | |
| #include <Kernel/Sections.h>
 | |
| #include <Kernel/Storage/IDEChannel.h>
 | |
| #include <Kernel/Storage/IDEController.h>
 | |
| #include <Kernel/Storage/PATADiskDevice.h>
 | |
| 
 | |
| namespace Kernel {
 | |
| 
 | |
| UNMAP_AFTER_INIT NonnullRefPtr<PATADiskDevice> PATADiskDevice::create(const IDEController& controller, IDEChannel& channel, DriveType type, InterfaceType interface_type, u16 capabilities, u64 max_addressable_block)
 | |
| {
 | |
|     auto device_or_error = try_create_device<PATADiskDevice>(controller, channel, type, interface_type, capabilities, max_addressable_block);
 | |
|     // FIXME: Find a way to propagate errors
 | |
|     VERIFY(!device_or_error.is_error());
 | |
|     return device_or_error.release_value();
 | |
| }
 | |
| 
 | |
| UNMAP_AFTER_INIT PATADiskDevice::PATADiskDevice(const IDEController& controller, IDEChannel& channel, DriveType type, InterfaceType interface_type, u16 capabilities, u64 max_addressable_block)
 | |
|     : StorageDevice(controller, 512, max_addressable_block)
 | |
|     , m_capabilities(capabilities)
 | |
|     , m_channel(channel)
 | |
|     , m_drive_type(type)
 | |
|     , m_interface_type(interface_type)
 | |
| {
 | |
| }
 | |
| 
 | |
| UNMAP_AFTER_INIT PATADiskDevice::~PATADiskDevice()
 | |
| {
 | |
| }
 | |
| 
 | |
| StringView PATADiskDevice::class_name() const
 | |
| {
 | |
|     return "PATADiskDevice";
 | |
| }
 | |
| 
 | |
| void PATADiskDevice::start_request(AsyncBlockDeviceRequest& request)
 | |
| {
 | |
|     m_channel->start_request(request, is_slave(), m_capabilities);
 | |
| }
 | |
| 
 | |
| String PATADiskDevice::storage_name() const
 | |
| {
 | |
|     return String::formatted("hd{:c}", 'a' + minor());
 | |
| }
 | |
| 
 | |
| bool PATADiskDevice::is_slave() const
 | |
| {
 | |
|     return m_drive_type == DriveType::Slave;
 | |
| }
 | |
| 
 | |
| }
 |