mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 03:22:43 +00:00 
			
		
		
		
	 f5de4f24b2
			
		
	
	
		f5de4f24b2
		
	
	
	
	
		
			
			Instead of doing so in the constructor, let's do immediately after the constructor, so we can safely pass a reference of a Device, so the SysFSDeviceComponent constructor can use that object to identify whether it's a block device or a character device. This allows to us to not hold a device in SysFSDeviceComponent with a RefPtr. Also, we also call the before_removing method in both SlavePTY::unref and File::unref, so because Device has that method being overrided, it can ensure the device is removed always cleanly.
		
			
				
	
	
		
			41 lines
		
	
	
	
		
			1.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			41 lines
		
	
	
	
		
			1.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <AK/RefPtr.h>
 | |
| #include <AK/WeakPtr.h>
 | |
| #include <Kernel/Devices/BlockDevice.h>
 | |
| #include <Kernel/Storage/Partition/DiskPartitionMetadata.h>
 | |
| 
 | |
| namespace Kernel {
 | |
| 
 | |
| class DiskPartition final : public BlockDevice {
 | |
| public:
 | |
|     static NonnullRefPtr<DiskPartition> create(BlockDevice&, unsigned, DiskPartitionMetadata);
 | |
|     virtual ~DiskPartition();
 | |
| 
 | |
|     virtual void start_request(AsyncBlockDeviceRequest&) override;
 | |
| 
 | |
|     // ^BlockDevice
 | |
|     virtual KResultOr<size_t> read(OpenFileDescription&, u64, UserOrKernelBuffer&, size_t) override;
 | |
|     virtual bool can_read(const OpenFileDescription&, size_t) const override;
 | |
|     virtual KResultOr<size_t> write(OpenFileDescription&, u64, const UserOrKernelBuffer&, size_t) override;
 | |
|     virtual bool can_write(const OpenFileDescription&, size_t) const override;
 | |
| 
 | |
|     const DiskPartitionMetadata& metadata() const;
 | |
| 
 | |
|     // FIXME: We expose this constructor to make try_create_device helper to work
 | |
|     DiskPartition(BlockDevice&, unsigned, DiskPartitionMetadata);
 | |
| 
 | |
| private:
 | |
|     virtual StringView class_name() const override;
 | |
| 
 | |
|     WeakPtr<BlockDevice> m_device;
 | |
|     DiskPartitionMetadata m_metadata;
 | |
| };
 | |
| 
 | |
| }
 |