1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-21 12:55:07 +00:00
serenity/Userland/Libraries/LibJS/Runtime/PropertyName.h
Idan Horowitz b9d9187feb LibJS: Automatically & lazily coerce PropertyNames into numbers
This commit expands on 5eef07d232 by
automatically trying to coerce Type::String PropertyNames into numbers
when a caller checks if the PropertyName is_number/is_string.
This has several benefits:
 - We no longer have to duplicate the number coercion code to every
   function that accepts a PropertyNumber. (Or more likely, forget to.)
 - This keeps the lazy nature of only doing the coercion when and if
   there is a semantic difference to the different PropertyName types,
   which means this shouldnt cause any performance drop.
 - Since this coercion changes the state of the PropertyName itself the
   result is essentially cached and can speed up any repeat uses of the
   same PropertyName instance.
2021-06-16 22:54:48 +01:00

191 lines
4.4 KiB
C++

/*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <AK/FlyString.h>
#include <LibJS/Runtime/StringOrSymbol.h>
namespace JS {
class PropertyName {
public:
enum class Type : u8 {
Invalid,
Number,
String,
Symbol,
};
enum class StringMayBeNumber {
Yes,
No,
};
static PropertyName from_value(GlobalObject& global_object, Value value)
{
if (value.is_empty())
return {};
if (value.is_symbol())
return &value.as_symbol();
if (value.is_integral_number() && value.as_i32() >= 0)
return value.as_i32();
auto string = value.to_string(global_object);
if (string.is_null())
return {};
return string;
}
PropertyName() { }
PropertyName(i32 index)
: m_type(Type::Number)
, m_number(index)
{
VERIFY(index >= 0);
}
PropertyName(char const* chars)
: m_type(Type::String)
, m_string(FlyString(chars))
{
}
PropertyName(String const& string)
: m_type(Type::String)
, m_string(FlyString(string))
{
VERIFY(!string.is_null());
}
PropertyName(FlyString const& string, StringMayBeNumber string_may_be_number = StringMayBeNumber::Yes)
: m_type(Type::String)
, m_string_may_be_number(string_may_be_number == StringMayBeNumber::Yes)
, m_string(string)
{
VERIFY(!string.is_null());
}
PropertyName(Symbol* symbol)
: m_type(Type::Symbol)
, m_symbol(symbol)
{
VERIFY(symbol);
}
PropertyName(StringOrSymbol const& string_or_symbol)
{
if (string_or_symbol.is_string()) {
m_string = string_or_symbol.as_string();
m_type = Type::String;
} else if (string_or_symbol.is_symbol()) {
m_symbol = const_cast<Symbol*>(string_or_symbol.as_symbol());
m_type = Type::Symbol;
}
}
bool is_valid() const { return m_type != Type::Invalid; }
bool is_number() const
{
if (m_type == Type::Number)
return true;
if (m_type != Type::String || !m_string_may_be_number)
return false;
return const_cast<PropertyName*>(this)->try_coerce_into_number();
}
bool is_string() const
{
if (m_type != Type::String)
return false;
if (!m_string_may_be_number)
return true;
return !const_cast<PropertyName*>(this)->try_coerce_into_number();
}
bool is_symbol() const { return m_type == Type::Symbol; }
bool try_coerce_into_number()
{
VERIFY(m_string_may_be_number);
i32 property_index = m_string.to_int().value_or(-1);
if (property_index < 0) {
m_string_may_be_number = false;
return false;
}
m_type = Type::Number;
m_number = property_index;
return true;
}
u32 as_number() const
{
VERIFY(is_number());
return m_number;
}
FlyString const& as_string() const
{
VERIFY(is_string());
return m_string;
}
Symbol const* as_symbol() const
{
VERIFY(is_symbol());
return m_symbol;
}
String to_string() const
{
VERIFY(is_valid());
VERIFY(!is_symbol());
if (is_string())
return as_string();
return String::number(as_number());
}
StringOrSymbol to_string_or_symbol() const
{
VERIFY(is_valid());
VERIFY(!is_number());
if (is_string())
return StringOrSymbol(as_string());
return StringOrSymbol(as_symbol());
}
Value to_value(VM& vm) const
{
if (is_string())
return js_string(vm, m_string);
if (is_number())
return Value(m_number);
if (is_symbol())
return m_symbol;
return js_undefined();
}
private:
Type m_type { Type::Invalid };
bool m_string_may_be_number { true };
FlyString m_string;
Symbol* m_symbol { nullptr };
u32 m_number { 0 };
};
}
namespace AK {
template<>
struct Formatter<JS::PropertyName> : Formatter<StringView> {
void format(FormatBuilder& builder, JS::PropertyName const& value)
{
Formatter<StringView>::format(builder, value.to_string());
}
};
}