mirror of
https://github.com/RGBCube/serenity
synced 2025-05-25 22:45:06 +00:00
a8a899adbf
Creating a menu/menubar needs to be synchronous because we need the ID from the response, but adding stuff *to* menus (and adding menus to menubars, and menubars to windows) can all be asynchronous. This dramatically reduces the amount of IPC ping-pong played by each GUI application during startup. I measured how long it takes TextEditor to enter the main event loop and it's over 10% faster here. (Down from ~86ms to ~74ms)
61 lines
1.2 KiB
C++
61 lines
1.2 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <AK/Badge.h>
|
|
#include <LibGUI/Menu.h>
|
|
#include <LibGUI/MenuItem.h>
|
|
#include <LibGUI/Menubar.h>
|
|
#include <LibGUI/WindowServerConnection.h>
|
|
|
|
namespace GUI {
|
|
|
|
Menubar::Menubar()
|
|
{
|
|
}
|
|
|
|
Menubar::~Menubar()
|
|
{
|
|
unrealize_menubar();
|
|
}
|
|
|
|
Menu& Menubar::add_menu(String name)
|
|
{
|
|
auto& menu = add<Menu>(move(name));
|
|
m_menus.append(menu);
|
|
return menu;
|
|
}
|
|
|
|
int Menubar::realize_menubar()
|
|
{
|
|
return WindowServerConnection::the().create_menubar();
|
|
}
|
|
|
|
void Menubar::unrealize_menubar()
|
|
{
|
|
if (m_menubar_id == -1)
|
|
return;
|
|
WindowServerConnection::the().destroy_menubar(m_menubar_id);
|
|
m_menubar_id = -1;
|
|
}
|
|
|
|
void Menubar::notify_added_to_window(Badge<Window>)
|
|
{
|
|
VERIFY(m_menubar_id == -1);
|
|
m_menubar_id = realize_menubar();
|
|
VERIFY(m_menubar_id != -1);
|
|
for (auto& menu : m_menus) {
|
|
int menu_id = menu.realize_menu();
|
|
VERIFY(menu_id != -1);
|
|
WindowServerConnection::the().async_add_menu_to_menubar(m_menubar_id, menu_id);
|
|
}
|
|
}
|
|
|
|
void Menubar::notify_removed_from_window(Badge<Window>)
|
|
{
|
|
unrealize_menubar();
|
|
}
|
|
|
|
}
|