mirror of
https://github.com/RGBCube/serenity
synced 2025-10-24 22:22:32 +00:00
830ea0414c
Before this we used an ad-hoc combination of references and 'variables'
stored in a hashmap. This worked in most cases but is not spec like.
Additionally hoisting, dynamically naming functions and scope analysis
was not done properly.
This patch fixes all of that by:
- Implement BindingInitialization for destructuring assignment.
- Implementing a new ScopePusher which tracks the lexical and var
scoped declarations. This hoists functions to the top level if no
lexical declaration name overlaps. Furthermore we do checking of
redeclarations in the ScopePusher now requiring less checks all over
the place.
- Add methods for parsing the directives and statement lists instead
of having that code duplicated in multiple places. This allows
declarations to pushed to the appropriate scope more easily.
- Remove the non spec way of storing 'variables' in
DeclarativeEnvironment and make Reference follow the spec instead of
checking both the bindings and 'variables'.
- Remove all scoping related things from the Interpreter. And instead
use environments as specified by the spec. This also includes fixing
that NativeFunctions did not produce a valid FunctionEnvironment
which could cause issues with callbacks and eval. All
FunctionObjects now have a valid NewFunctionEnvironment
implementation.
- Remove execute_statements from Interpreter and instead use
ASTNode::execute everywhere this simplifies AST.cpp as you no longer
need to worry about which method to call.
- Make ScopeNodes setup their own environment. This uses four
different methods specified by the spec
{Block, Function, Eval, Global}DeclarationInstantiation with the
annexB extensions.
- Implement and use NamedEvaluation where specified.
Additionally there are fixes to things exposed by these changes to eval,
{for, for-in, for-of} loops and assignment.
Finally it also fixes some tests in test-js which where passing before
but not now that we have correct behavior :^).
119 lines
3 KiB
JavaScript
119 lines
3 KiB
JavaScript
describe("correct behavior", () => {
|
|
test("iterate through array", () => {
|
|
const a = [];
|
|
for (const num of [1, 2, 3]) {
|
|
a.push(num);
|
|
}
|
|
expect(a).toEqual([1, 2, 3]);
|
|
});
|
|
|
|
test("iterate through string", () => {
|
|
const a = [];
|
|
for (const char of "hello") {
|
|
a.push(char);
|
|
}
|
|
expect(a).toEqual(["h", "e", "l", "l", "o"]);
|
|
});
|
|
|
|
test("iterate through string object", () => {
|
|
const a = [];
|
|
for (const char of new String("hello")) {
|
|
a.push(char);
|
|
}
|
|
expect(a).toEqual(["h", "e", "l", "l", "o"]);
|
|
});
|
|
|
|
test("use already-declared variable", () => {
|
|
var char;
|
|
for (char of "abc");
|
|
expect(char).toBe("c");
|
|
});
|
|
|
|
test("respects custom Symbol.iterator method", () => {
|
|
const o = {
|
|
[Symbol.iterator]() {
|
|
return {
|
|
i: 0,
|
|
next() {
|
|
if (this.i++ == 3) {
|
|
return { done: true };
|
|
}
|
|
return { value: this.i, done: false };
|
|
},
|
|
};
|
|
},
|
|
};
|
|
|
|
const a = [];
|
|
for (const k of o) {
|
|
a.push(k);
|
|
}
|
|
|
|
expect(a).toEqual([1, 2, 3]);
|
|
});
|
|
|
|
test("loops through custom iterator if there is an exception thrown part way through", () => {
|
|
// This tests against the way custom iterators used to be implemented, where the values
|
|
// were all collected at once before the for-of body was executed, instead of getting
|
|
// the values one at a time
|
|
const o = {
|
|
[Symbol.iterator]() {
|
|
return {
|
|
i: 0,
|
|
next() {
|
|
if (this.i++ === 3) {
|
|
throw new Error();
|
|
}
|
|
return { value: this.i };
|
|
},
|
|
};
|
|
},
|
|
};
|
|
|
|
const a = [];
|
|
|
|
try {
|
|
for (let k of o) {
|
|
a.push(k);
|
|
}
|
|
expect().fail();
|
|
} catch (e) {
|
|
expect(a).toEqual([1, 2, 3]);
|
|
}
|
|
});
|
|
});
|
|
|
|
describe("errors", () => {
|
|
test("right hand side is a primitive", () => {
|
|
expect(() => {
|
|
for (const _ of 123) {
|
|
}
|
|
}).toThrowWithMessage(TypeError, "123 is not iterable");
|
|
});
|
|
|
|
test("right hand side is an object", () => {
|
|
expect(() => {
|
|
for (const _ of { foo: 1, bar: 2 }) {
|
|
}
|
|
}).toThrowWithMessage(TypeError, "[object Object] is not iterable");
|
|
});
|
|
});
|
|
|
|
test("allow binding patterns", () => {
|
|
let counter = 0;
|
|
for (let [a, b] of [
|
|
[1, 2],
|
|
[3, 4],
|
|
[5, 6],
|
|
]) {
|
|
expect(a + 1).toBe(b);
|
|
counter++;
|
|
}
|
|
expect(counter).toBe(3);
|
|
});
|
|
|
|
test("allow member expression as variable", () => {
|
|
const f = {};
|
|
for (f.a of "abc");
|
|
expect(f.a).toBe("c");
|
|
});
|