mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 19:22:45 +00:00 
			
		
		
		
	 a05fd28b7b
			
		
	
	
		a05fd28b7b
		
	
	
	
	
		
			
			The styling of elements using the `use_pseudo_element()` was only applied on layout. When an element style was recomputed later that styling was not overruled with the pseudo element selector styles. This moves the styling override from `TreeBuilder.cpp` to `StyleComputer.cpp`. Now the styles are always correctly applied. I also removed the method `property_id_by_index()` because it was not needed anymore. Als some calls to `invalidate_layout()` in the Meter, Progress and Select elements where not needed anymore because the style values are update on the changing of the style attribute. This fixes issue #22278.
		
			
				
	
	
		
			42 lines
		
	
	
	
		
			1.3 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			42 lines
		
	
	
	
		
			1.3 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2021-2023, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <LibWeb/CSS/CSSStyleDeclaration.h>
 | |
| 
 | |
| namespace Web::CSS {
 | |
| 
 | |
| class ResolvedCSSStyleDeclaration final : public CSSStyleDeclaration {
 | |
|     WEB_PLATFORM_OBJECT(ResolvedCSSStyleDeclaration, CSSStyleDeclaration);
 | |
|     JS_DECLARE_ALLOCATOR(ResolvedCSSStyleDeclaration);
 | |
| 
 | |
| public:
 | |
|     [[nodiscard]] static JS::NonnullGCPtr<ResolvedCSSStyleDeclaration> create(DOM::Element&);
 | |
| 
 | |
|     virtual ~ResolvedCSSStyleDeclaration() override = default;
 | |
| 
 | |
|     virtual size_t length() const override;
 | |
|     virtual String item(size_t index) const override;
 | |
| 
 | |
|     virtual Optional<StyleProperty> property(PropertyID) const override;
 | |
|     virtual WebIDL::ExceptionOr<void> set_property(PropertyID, StringView css_text, StringView priority) override;
 | |
|     virtual WebIDL::ExceptionOr<String> remove_property(PropertyID) override;
 | |
| 
 | |
|     virtual String serialized() const override;
 | |
|     virtual WebIDL::ExceptionOr<void> set_css_text(StringView) override;
 | |
| 
 | |
| private:
 | |
|     explicit ResolvedCSSStyleDeclaration(DOM::Element&);
 | |
| 
 | |
|     virtual void visit_edges(Cell::Visitor&) override;
 | |
| 
 | |
|     RefPtr<StyleValue const> style_value_for_property(Layout::NodeWithStyle const&, PropertyID) const;
 | |
| 
 | |
|     JS::NonnullGCPtr<DOM::Element> m_element;
 | |
| };
 | |
| 
 | |
| }
 |