mirror of
https://github.com/RGBCube/serenity
synced 2025-05-19 03:05:06 +00:00
f3d57e1157
Since handling overflow: hidden in PaintableBox::before_children_paint while following paint traversal order can't result in correctly computed clip rectangle for elements that create their own stacking context (because before_children_paint is called only for parent but overflow: hidden can be set somewhere deeper but not in direct ancestor), here introduced new function PaintableBox::clip_rect() that computes clip rectangle by looking into containing block. should_clip_overflow flag that disables clip for absolutely positioned elements in before_children_paint and after_children_paint is removed because after changing clip rectangle to be computed from not parent but containing block it is not needed anymore (absolutely positioned item is clipped if it's containing block has hidden overflow)
50 lines
1.4 KiB
C++
50 lines
1.4 KiB
C++
/*
|
|
* Copyright (c) 2018-2022, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Layout/ImageBox.h>
|
|
#include <LibWeb/Layout/SVGSVGBox.h>
|
|
#include <LibWeb/Painting/SVGPaintable.h>
|
|
|
|
namespace Web::Painting {
|
|
|
|
SVGPaintable::SVGPaintable(Layout::SVGBox const& layout_box)
|
|
: PaintableBox(layout_box)
|
|
{
|
|
}
|
|
|
|
Layout::SVGBox const& SVGPaintable::layout_box() const
|
|
{
|
|
return static_cast<Layout::SVGBox const&>(layout_node());
|
|
}
|
|
|
|
void SVGPaintable::before_children_paint(PaintContext& context, PaintPhase phase) const
|
|
{
|
|
PaintableBox::before_children_paint(context, phase);
|
|
if (phase != PaintPhase::Foreground)
|
|
return;
|
|
context.svg_context().save();
|
|
}
|
|
|
|
void SVGPaintable::after_children_paint(PaintContext& context, PaintPhase phase) const
|
|
{
|
|
PaintableBox::after_children_paint(context, phase);
|
|
if (phase != PaintPhase::Foreground)
|
|
return;
|
|
context.svg_context().restore();
|
|
}
|
|
|
|
Gfx::FloatRect SVGPaintable::compute_absolute_rect() const
|
|
{
|
|
if (auto* svg_svg_box = layout_box().first_ancestor_of_type<Layout::SVGSVGBox>()) {
|
|
Gfx::FloatRect rect { effective_offset(), content_size() };
|
|
for (Layout::Box const* ancestor = svg_svg_box; ancestor && ancestor->paintable(); ancestor = ancestor->paintable()->containing_block())
|
|
rect.translate_by(ancestor->paint_box()->effective_offset());
|
|
return rect;
|
|
}
|
|
return PaintableBox::compute_absolute_rect();
|
|
}
|
|
|
|
}
|