1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:18:12 +00:00
serenity/Servers/LookupServer/DNSRequest.cpp
Andreas Kling b4d55b16b6 LookupServer: Randomize the 0x20 bit in DNS request ASCII characters
This adds a bit of extra entropy to DNS requests, making it harder to
spoof a valid response.

Suggested by @zecke in #10.
2020-01-26 13:07:21 +01:00

70 lines
1.7 KiB
C++

#include "DNSRequest.h"
#include "DNSPacket.h"
#include <AK/BufferStream.h>
#include <AK/StringBuilder.h>
#include <arpa/inet.h>
#include <ctype.h>
#include <stdlib.h>
#define C_IN 1
DNSRequest::DNSRequest()
: m_id(arc4random_uniform(UINT16_MAX))
{
}
void DNSRequest::add_question(const String& name, u16 record_type)
{
ASSERT(m_questions.size() <= UINT16_MAX);
if (name.is_empty())
return;
// Randomize the 0x20 bit in every ASCII character.
StringBuilder builder;
for (size_t i = 0; i < name.length(); ++i) {
u8 ch = name[i];
if (isalpha(ch)) {
if (arc4random_uniform(2))
ch |= 0x20;
else
ch &= ~0x20;
}
builder.append(ch);
}
if (name[name.length() - 1] != '.')
builder.append('.');
m_questions.empend(builder.to_string(), record_type, C_IN);
}
ByteBuffer DNSRequest::to_byte_buffer() const
{
DNSPacket request_header;
request_header.set_id(m_id);
request_header.set_is_query();
request_header.set_opcode(0);
request_header.set_truncated(false);
request_header.set_recursion_desired(true);
request_header.set_question_count(m_questions.size());
auto buffer = ByteBuffer::create_uninitialized(m_questions.size() * 4096);
BufferStream stream(buffer);
stream << ByteBuffer::wrap(&request_header, sizeof(request_header));
for (auto& question : m_questions) {
auto parts = question.name().split('.');
for (auto& part : parts) {
stream << (u8)part.length();
stream << part;
}
stream << '\0';
stream << htons(question.record_type());
stream << htons(question.class_code());
}
stream.snip();
return buffer;
}