mirror of
https://github.com/RGBCube/serenity
synced 2026-01-20 19:30:59 +00:00
9ea6ef4ed1
The motivation for this change is twofold: - Returning a JS::Value is misleading as one would expect it to carry some meaningful information, like maybe the error object that's being created, but in fact it is always empty. Supposedly to serve as a shortcut for the common case of "throw and return empty value", but that's just leading us to my second point. - Inconsistent usage / coding style: as of this commit there are 114 uses of throw_exception() discarding its return value and 55 uses directly returning the call result (in LibJS, not counting LibWeb); with the first style often having a more explicit empty value (or nullptr in some cases) return anyway. One more line to always make the return value obvious is should be worth it. So now it's basically always these steps, which is already being used in the majority of cases (as outlined above): - Throw an exception. This mutates interpreter state by updating m_exception and unwinding, but doesn't return anything. - Let the caller explicitly return an empty value, nullptr or anything else itself. |
||
|---|---|---|
| .. | ||
| CellSyntaxHighlighter.cpp | ||
| CellSyntaxHighlighter.h | ||
| CMakeLists.txt | ||
| HelpWindow.cpp | ||
| HelpWindow.h | ||
| main.cpp | ||
| Spreadsheet.cpp | ||
| Spreadsheet.h | ||
| SpreadsheetModel.cpp | ||
| SpreadsheetModel.h | ||
| SpreadsheetView.cpp | ||
| SpreadsheetView.h | ||
| SpreadsheetWidget.cpp | ||
| SpreadsheetWidget.h | ||