mirror of
https://github.com/RGBCube/serenity
synced 2025-05-22 19:35:06 +00:00

Found due to smelly code in InodeFile::absolute_path. In particular, this replaces the following misleading methods: File::absolute_path This method *never* returns an actual path, and if called on an InodeFile (which is impossible), it would VERIFY_NOT_REACHED(). OpenFileDescription::try_serialize_absolute_path OpenFileDescription::absolute_path These methods do not guarantee to return an actual path (just like the other method), and just like Custody::absolute_path they do not guarantee accuracy. In particular, just renaming the method made a TOCTOU bug obvious. The new method signatures use KResultOr, just like try_serialize_absolute_path() already did.
162 lines
5.8 KiB
C++
162 lines
5.8 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <AK/Singleton.h>
|
|
#include <Kernel/Devices/Device.h>
|
|
#include <Kernel/Devices/DeviceManagement.h>
|
|
#include <Kernel/FileSystem/InodeMetadata.h>
|
|
#include <Kernel/FileSystem/SysFS.h>
|
|
#include <Kernel/Sections.h>
|
|
|
|
namespace Kernel {
|
|
|
|
NonnullRefPtr<SysFSDeviceComponent> SysFSDeviceComponent::must_create(Device const& device)
|
|
{
|
|
return adopt_ref_if_nonnull(new SysFSDeviceComponent(device)).release_nonnull();
|
|
}
|
|
SysFSDeviceComponent::SysFSDeviceComponent(Device const& device)
|
|
: SysFSComponent(String::formatted("{}:{}", device.major(), device.minor()))
|
|
, m_block_device(device.is_block_device())
|
|
{
|
|
VERIFY(device.is_block_device() || device.is_character_device());
|
|
}
|
|
|
|
UNMAP_AFTER_INIT NonnullRefPtr<SysFSDevicesDirectory> SysFSDevicesDirectory::must_create(SysFSRootDirectory const& root_directory)
|
|
{
|
|
auto devices_directory = adopt_ref_if_nonnull(new SysFSDevicesDirectory(root_directory)).release_nonnull();
|
|
devices_directory->m_components.append(SysFSBlockDevicesDirectory::must_create(*devices_directory));
|
|
devices_directory->m_components.append(SysFSCharacterDevicesDirectory::must_create(*devices_directory));
|
|
return devices_directory;
|
|
}
|
|
SysFSDevicesDirectory::SysFSDevicesDirectory(SysFSRootDirectory const& root_directory)
|
|
: SysFSDirectory("dev"sv, root_directory)
|
|
{
|
|
}
|
|
|
|
NonnullRefPtr<SysFSBlockDevicesDirectory> SysFSBlockDevicesDirectory::must_create(SysFSDevicesDirectory const& devices_directory)
|
|
{
|
|
return adopt_ref_if_nonnull(new SysFSBlockDevicesDirectory(devices_directory)).release_nonnull();
|
|
}
|
|
SysFSBlockDevicesDirectory::SysFSBlockDevicesDirectory(SysFSDevicesDirectory const& devices_directory)
|
|
: SysFSDirectory("block"sv, devices_directory)
|
|
{
|
|
}
|
|
KResult SysFSBlockDevicesDirectory::traverse_as_directory(unsigned fsid, Function<bool(FileSystem::DirectoryEntryView const&)> callback) const
|
|
{
|
|
VERIFY(m_parent_directory);
|
|
callback({ ".", { fsid, component_index() }, 0 });
|
|
callback({ "..", { fsid, m_parent_directory->component_index() }, 0 });
|
|
|
|
SysFSComponentRegistry::the().devices_list().with_exclusive([&](auto& list) -> void {
|
|
for (auto& exposed_device : list) {
|
|
if (!exposed_device.is_block_device())
|
|
continue;
|
|
callback({ exposed_device.name(), { fsid, exposed_device.component_index() }, 0 });
|
|
}
|
|
});
|
|
return KSuccess;
|
|
}
|
|
RefPtr<SysFSComponent> SysFSBlockDevicesDirectory::lookup(StringView name)
|
|
{
|
|
return SysFSComponentRegistry::the().devices_list().with_exclusive([&](auto& list) -> RefPtr<SysFSComponent> {
|
|
for (auto& exposed_device : list) {
|
|
if (!exposed_device.is_block_device())
|
|
continue;
|
|
if (exposed_device.name() == name)
|
|
return exposed_device;
|
|
}
|
|
return nullptr;
|
|
});
|
|
}
|
|
|
|
NonnullRefPtr<SysFSCharacterDevicesDirectory> SysFSCharacterDevicesDirectory::must_create(SysFSDevicesDirectory const& devices_directory)
|
|
{
|
|
return adopt_ref_if_nonnull(new SysFSCharacterDevicesDirectory(devices_directory)).release_nonnull();
|
|
}
|
|
SysFSCharacterDevicesDirectory::SysFSCharacterDevicesDirectory(SysFSDevicesDirectory const& devices_directory)
|
|
: SysFSDirectory("char"sv, devices_directory)
|
|
{
|
|
}
|
|
KResult SysFSCharacterDevicesDirectory::traverse_as_directory(unsigned fsid, Function<bool(FileSystem::DirectoryEntryView const&)> callback) const
|
|
{
|
|
VERIFY(m_parent_directory);
|
|
callback({ ".", { fsid, component_index() }, 0 });
|
|
callback({ "..", { fsid, m_parent_directory->component_index() }, 0 });
|
|
|
|
SysFSComponentRegistry::the().devices_list().with_exclusive([&](auto& list) -> void {
|
|
for (auto& exposed_device : list) {
|
|
if (exposed_device.is_block_device())
|
|
continue;
|
|
callback({ exposed_device.name(), { fsid, exposed_device.component_index() }, 0 });
|
|
}
|
|
});
|
|
return KSuccess;
|
|
}
|
|
RefPtr<SysFSComponent> SysFSCharacterDevicesDirectory::lookup(StringView name)
|
|
{
|
|
return SysFSComponentRegistry::the().devices_list().with_exclusive([&](auto& list) -> RefPtr<SysFSComponent> {
|
|
for (auto& exposed_device : list) {
|
|
if (exposed_device.is_block_device())
|
|
continue;
|
|
if (exposed_device.name() == name)
|
|
return exposed_device;
|
|
}
|
|
return nullptr;
|
|
});
|
|
}
|
|
|
|
Device::Device(unsigned major, unsigned minor)
|
|
: m_major(major)
|
|
, m_minor(minor)
|
|
{
|
|
}
|
|
|
|
void Device::after_inserting()
|
|
{
|
|
DeviceManagement::the().after_inserting_device({}, *this);
|
|
VERIFY(!m_sysfs_component);
|
|
auto sys_fs_component = SysFSDeviceComponent::must_create(*this);
|
|
m_sysfs_component = sys_fs_component;
|
|
SysFSComponentRegistry::the().devices_list().with_exclusive([&](auto& list) -> void {
|
|
list.append(sys_fs_component);
|
|
});
|
|
}
|
|
|
|
void Device::before_removing()
|
|
{
|
|
VERIFY(m_sysfs_component);
|
|
SysFSComponentRegistry::the().devices_list().with_exclusive([&](auto& list) -> void {
|
|
list.remove(*m_sysfs_component);
|
|
});
|
|
DeviceManagement::the().before_device_removal({}, *this);
|
|
m_state = State::BeingRemoved;
|
|
}
|
|
|
|
Device::~Device()
|
|
{
|
|
VERIFY(m_state == State::BeingRemoved);
|
|
}
|
|
|
|
KResultOr<NonnullOwnPtr<KString>> Device::pseudo_path(const OpenFileDescription&) const
|
|
{
|
|
return KString::try_create(String::formatted("device:{},{}", major(), minor()));
|
|
}
|
|
|
|
void Device::process_next_queued_request(Badge<AsyncDeviceRequest>, const AsyncDeviceRequest& completed_request)
|
|
{
|
|
SpinlockLocker lock(m_requests_lock);
|
|
VERIFY(!m_requests.is_empty());
|
|
VERIFY(m_requests.first().ptr() == &completed_request);
|
|
m_requests.remove(m_requests.begin());
|
|
if (!m_requests.is_empty()) {
|
|
auto* next_request = m_requests.first().ptr();
|
|
next_request->do_start(move(lock));
|
|
}
|
|
|
|
evaluate_block_conditions();
|
|
}
|
|
|
|
}
|