mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 03:22:43 +00:00 
			
		
		
		
	 655d9d1462
			
		
	
	
		655d9d1462
		
	
	
	
	
		
			
			This fixes a plethora of rounding problems on many websites. In the future, we may want to replace this with fixed-point arithmetic (bug #18566) for performance (and consistency with other engines), but in the meantime this makes the web look a bit better. :^) There's a lot more things that could be converted to doubles, which would reduce the amount of casting necessary in this patch. We can do that incrementally, however.
		
			
				
	
	
		
			55 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			55 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2023, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <AK/URL.h>
 | |
| #include <AK/Variant.h>
 | |
| #include <LibWeb/CSS/Length.h>
 | |
| 
 | |
| namespace Web::HTML {
 | |
| 
 | |
| // https://html.spec.whatwg.org/multipage/images.html#image-source
 | |
| struct ImageSource {
 | |
|     struct PixelDensityDescriptorValue {
 | |
|         double value { 0 };
 | |
|     };
 | |
| 
 | |
|     struct WidthDescriptorValue {
 | |
|         CSSPixels value { 0 };
 | |
|     };
 | |
| 
 | |
|     String url;
 | |
|     Variant<Empty, PixelDensityDescriptorValue, WidthDescriptorValue> descriptor;
 | |
| };
 | |
| 
 | |
| struct ImageSourceAndPixelDensity {
 | |
|     ImageSource source;
 | |
|     double pixel_density { 1.0f };
 | |
| };
 | |
| 
 | |
| // https://html.spec.whatwg.org/multipage/images.html#source-set
 | |
| struct SourceSet {
 | |
|     static SourceSet create(DOM::Document const&, String default_source, String srcset, String sizes);
 | |
| 
 | |
|     [[nodiscard]] bool is_empty() const;
 | |
| 
 | |
|     // https://html.spec.whatwg.org/multipage/images.html#select-an-image-source-from-a-source-set
 | |
|     [[nodiscard]] ImageSourceAndPixelDensity select_an_image_source();
 | |
| 
 | |
|     // https://html.spec.whatwg.org/multipage/images.html#normalise-the-source-densities
 | |
|     void normalize_source_densities();
 | |
| 
 | |
|     SourceSet();
 | |
| 
 | |
|     Vector<ImageSource> m_sources;
 | |
|     CSS::Length m_source_size;
 | |
| };
 | |
| 
 | |
| SourceSet parse_a_srcset_attribute(StringView);
 | |
| CSS::Length parse_a_sizes_attribute(DOM::Document const&, StringView);
 | |
| 
 | |
| }
 |