mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 13:22:43 +00:00 
			
		
		
		
	 963a6b3d3d
			
		
	
	
		963a6b3d3d
		
	
	
	
	
		
			
			We were calling write syscall twice for every sample, which effectively hurt the writer's performance. With this change exporting a melody in the Piano app now takes less than a second, which previously took about 20 seconds on my machine. Additionally, I've removed an unused `WavWriter::file()` getter.
		
			
				
	
	
		
			53 lines
		
	
	
	
		
			1.7 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			53 lines
		
	
	
	
		
			1.7 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2020, William McPherson <willmcpherson2@gmail.com>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <AK/DeprecatedString.h>
 | |
| #include <AK/Noncopyable.h>
 | |
| #include <AK/RefPtr.h>
 | |
| #include <AK/StringView.h>
 | |
| #include <LibAudio/Encoder.h>
 | |
| #include <LibAudio/Sample.h>
 | |
| #include <LibAudio/SampleFormats.h>
 | |
| #include <LibCore/File.h>
 | |
| #include <LibCore/Forward.h>
 | |
| 
 | |
| namespace Audio {
 | |
| 
 | |
| class WavWriter : public Encoder {
 | |
|     AK_MAKE_NONCOPYABLE(WavWriter);
 | |
|     AK_MAKE_NONMOVABLE(WavWriter);
 | |
| 
 | |
| public:
 | |
|     static ErrorOr<NonnullOwnPtr<WavWriter>> create_from_file(StringView path, int sample_rate = 44100, u16 num_channels = 2, PcmSampleFormat sample_format = PcmSampleFormat::Int16);
 | |
|     WavWriter(int sample_rate = 44100, u16 num_channels = 2, PcmSampleFormat sample_format = PcmSampleFormat::Int16);
 | |
|     ~WavWriter();
 | |
| 
 | |
|     virtual ErrorOr<void> write_samples(ReadonlySpan<Sample> samples) override;
 | |
|     virtual ErrorOr<void> finalize() override;
 | |
| 
 | |
|     u32 sample_rate() const { return m_sample_rate; }
 | |
|     u16 num_channels() const { return m_num_channels; }
 | |
|     PcmSampleFormat sample_format() const { return m_sample_format; }
 | |
| 
 | |
|     ErrorOr<void> set_file(StringView path);
 | |
|     void set_num_channels(int num_channels) { m_num_channels = num_channels; }
 | |
|     void set_sample_rate(int sample_rate) { m_sample_rate = sample_rate; }
 | |
|     void set_sample_format(PcmSampleFormat sample_format) { m_sample_format = sample_format; }
 | |
| 
 | |
| private:
 | |
|     ErrorOr<void> write_header();
 | |
|     OwnPtr<Core::OutputBufferedFile> m_file;
 | |
|     bool m_finalized { false };
 | |
| 
 | |
|     u32 m_sample_rate;
 | |
|     u16 m_num_channels;
 | |
|     PcmSampleFormat m_sample_format;
 | |
|     u32 m_data_sz { 0 };
 | |
| };
 | |
| 
 | |
| }
 |